Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "inc" to HEADER_FILES_EXTENSIONS #597

Closed
mozeryansky opened this issue Aug 10, 2018 · 7 comments · Fixed by #598
Closed

Add "inc" to HEADER_FILES_EXTENSIONS #597

mozeryansky opened this issue Aug 10, 2018 · 7 comments · Fixed by #598

Comments

@mozeryansky
Copy link

We have created a podspec for a c++ project, but they use ".inc" for extensions to their header files. Can we either add ".inc" or make a way to specify additional extensions for headers.

Here's a relevant conversation: CocoaPods/CocoaPods#3708

@dnkoutso
Copy link
Contributor

This should be fairly easy to do https://github.com/CocoaPods/Xcodeproj/blob/master/lib/xcodeproj/constants.rb#L419

I read your other reply, historically this list doesnt change that often (last time it was changed was December 13th 2017).

I believe the burden of adding the ability to customize these extension is actually higher than the fixed list.

The PR should be simple and we can get it merged quickly.

@mozeryansky
Copy link
Author

I agree that the right solution would not be appending to that list, but to allow custom extensions. Common extensions should be in that list.

@mozeryansky
Copy link
Author

Ha there already is a PR for adding ".cc"

#514

@dnkoutso
Copy link
Contributor

Seems like the .cc one went through a different path.

@mozeryansky
Copy link
Author

".inc" was already added! #598

@dnkoutso
Copy link
Contributor

@mozeryansky I just did this in this PR? what do you mean?

@mozeryansky
Copy link
Author

Oh, yes. Very fast. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants