Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod lib create pass over arguments to the template's configure #2160

Closed
kylef opened this issue May 21, 2014 · 3 comments · Fixed by #3627
Closed

pod lib create pass over arguments to the template's configure #2160

kylef opened this issue May 21, 2014 · 3 comments · Fixed by #3627
Assignees
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future.

Comments

@kylef
Copy link
Contributor

kylef commented May 21, 2014

I think this would be nice to configure your templates, example usage:

$ pod lib create Name --ios --github=kylef --template="https://github.com/kylef/private-pod-template"

Would would invoke the following on the template:

$ ./configure Name --ios --github=kylef

/cc @orta @pietbrauer

@orta
Copy link
Member

orta commented May 22, 2014

yes

@fabiopelosin
Copy link
Member

As CLAide is designed the options need to be declared in advance to be acceptable. However the options are not know until the template is downloaded which might change them.

The only reasonable way that I see to support this is to parse some kind of string. Not pretty:

pod lib create Name https://github.com/kylef/private-pod-template --configuration='platform:ios'

Alternatively we could introduce options for some important configurations --ios and --osx is one. And try to fallback to others (maybe with an option like --defaults) to allow to generate a template without further user input.

@alloy
Copy link
Member

alloy commented Sep 15, 2014

As CLAide is designed the options need to be declared in advance to be acceptable. However the options are not know until the template is downloaded which might change them.

You can possibly save all the extra (unknown) arguments and then pass them to the template script after downloading and have the script return any unknown arguments to the command which in turn can then call help! again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants