Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ZSH completion code #43

Closed
alloy opened this issue Nov 12, 2014 · 7 comments
Closed

Remove ZSH completion code #43

alloy opened this issue Nov 12, 2014 · 7 comments

Comments

@alloy
Copy link
Member

alloy commented Nov 12, 2014

It’s not used by all users or even developers that work on CLAide, so it’s quality cannot be guaranteed.

In addition it appears that it doesn’t fully work well, @AliSoftware can you comment on that?

All in all, it’s bloat and as such should be moved out of this library, possibly into a plugin, which could just be a CocoaPods plugin for now.

@alloy
Copy link
Member Author

alloy commented Nov 12, 2014

And, with it, all code related to shell completion.

@AliSoftware
Copy link
Contributor

By its nature of being statically generated it does not allow completion on arguments other than subcommands and options, namely path.

E.g. pod update OHH+[tab] does not autocomplete the path / filename

@kylef
Copy link
Contributor

kylef commented Nov 12, 2014

I agree that it should become a plugin. Considering that you need to invoke a command to get the completion code, I think it's fair that we just add an extra line to the instructions, it doesn't necessarily need to be bundled with CocoaPods.

$ gem install claide-completion
$ pod --completion-script > /usr/local/share/zsh/site-functions/_pod
$ exec zsh

@alloy alloy closed this as completed in 423275a Nov 13, 2014
@alloy
Copy link
Member Author

alloy commented Nov 13, 2014

Re-opening, because there still needs to be a claide-zsh_completion plugin, but the support is there.

@segiddins
Copy link
Member

@alloy should be accomplished by https://github.com/CocoaPods/claide-completion, which I will release as soon as you give me a 👍

@segiddins segiddins self-assigned this Jun 28, 2015
@alloy
Copy link
Member Author

alloy commented Jun 28, 2015

Hahaha, that readme is excellent, do it 👍

@segiddins
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants