Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactoring and cleanup of the repo #20

Open
4 of 5 tasks
gianlucatruda opened this issue Apr 6, 2020 · 7 comments
Open
4 of 5 tasks

General refactoring and cleanup of the repo #20

gianlucatruda opened this issue Apr 6, 2020 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@gianlucatruda
Copy link
Collaborator

gianlucatruda commented Apr 6, 2020

TODO:

@gianlucatruda gianlucatruda added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Apr 6, 2020
@gianlucatruda
Copy link
Collaborator Author

gianlucatruda commented Apr 6, 2020

Proposed project structure to make the repo more modular and accessible:

Spo2_evaluation/
├── README.md
├── evaluation
│   ├── README.md
│   ├── Spo2_evaluation.py
│   ├── blant_altman.py
│   ├── test.py
│   └── test_normal.py
├── misc
│   ├── VideoDataAcquisition.java
│   └── fetch_data.py
├── modelling
│   ├── NN_models
│   ├── healthwatcher
│   ├── lamonaca_and_nemcova
│   └── wang_2017
├── preprocessed_data
│   ├── README.md
│   ├── nemcova_data
│   └── sample_data
├── preprocessing
│   ├── README.md
│   ├── data_loader.py
│   ├── structure.py
│   └── utils.py
└── requirements.txt

@MalcolmMielle
Copy link
Contributor

I think we should remove the videos inside the video_data folder from the repo entirely and instead add a bunch of loading scripts in Python so we don't increase the size of the repo too much with videos.

I see multiple solution scripts we could make available:

  • Local load of the dataset from Dropbox or other provider
  • Batch load of a subset of a dataset from an online source so that the user doesn't have to download all the data in one go.

@gianlucatruda
Copy link
Collaborator Author

I think we should remove the videos inside the video_data folder from the repo entirely and instead add a bunch of loading scripts in Python so we don't increase the size of the repo too much with videos.

I agree! I'll have a look at ways we could request, unzip, and arrange the data via a simple script.

@gianlucatruda
Copy link
Collaborator Author

I've started reorganising the project in the refactoring branch. PR #22

@LittlePea13
Copy link
Collaborator

Maybe add the NN models in the modelling folder?

@gianlucatruda
Copy link
Collaborator Author

Maybe add the NN models in the modelling folder?

@LittlePea13 Yes! Thanks! They weren't yet merged when I was doing this initially, but I've added them now.

@gianlucatruda
Copy link
Collaborator Author

gianlucatruda commented Apr 6, 2020

@MalcolmMielle I've added a script for fetching and unzipping the data files

https://github.com/CoVital-Project/Spo2_evaluation/blob/refactoring/misc/fetch_data.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants