Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification settings probably lost on update #70

Open
ignyx opened this issue Jan 2, 2023 · 0 comments
Open

Notification settings probably lost on update #70

ignyx opened this issue Jan 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ignyx
Copy link
Contributor

ignyx commented Jan 2, 2023

Currently, notification channel ids contain the Update.number constant in order to be able to change the placeholder text. Whenever the Update.number constant is changed in a release, the old channels are removed then new channels are added (for example channel amicale7 could become amicale8), allowing the text to be changed.

This likely has the consequence of losing the setting. If a user disables certain notifications, they expect them to stay disabled after an update.

Approaches that have come to mind :

  • remove the dependence on Update.number to provide consistency.
  • use hard-coded channel versions (we could have amicale2 and washer3 at the same time). We would then update the channel ids whenever we want to make a change to placeholder text
@ignyx ignyx added bug Something isn't working good for beginners Issues simple to resolve labels Jan 2, 2023
@ignyx ignyx removed the good for beginners Issues simple to resolve label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant