Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly instruct BALSAMIC to run QC workflow for MH cases #825

Closed
hassanfa opened this issue Nov 6, 2020 · 8 comments
Closed

Properly instruct BALSAMIC to run QC workflow for MH cases #825

hassanfa opened this issue Nov 6, 2020 · 8 comments
Assignees
Labels
Balsamic Issued related to the Balsamic workflow Effort M Gain M Urgency M

Comments

@hassanfa
Copy link
Contributor

hassanfa commented Nov 6, 2020

BALSAMIC is capable running in qc only mode since release 3.X.X. And cg is supporting it since couple of month ago: #687

Related prio 3 project: https://github.com/Clinical-Genomics/cgp-mh-fastq-delivery

MH samples can be problematic and break variant calling runs for various reasons (it is outside of scope of this issue), so we preferably want to run only QC for these samples so we can deliver trimmed fastq files.

  1. Run QC only for BALSAMIC cases, so it can finish workflow properly.
  2. Store qc trimmed fastq files

This is related to AMDoc 1046 (fastq delivery MH).

I'm fully aware of Trailblazer can mark cases as finished, but BALSAMIC won't prepare a delivery file unless it is properly finished (the feature to deliver without finishing workflow will be deprecated, i.e. if there is any file missing, it won't prepare the file. This is due to refactoring I'll be doing to prepare unique tags for sake of housekeeper store smoothness).

@Mropat
Copy link
Contributor

Mropat commented Nov 7, 2020

So what is the proposed solution?
Do we want to introduce a delivery field in Status to indicate delivery type and handle these cases accordingly?

@vwirta
Copy link

vwirta commented Nov 7, 2020

There will be many cases in future where we would like to run only QC part of Balsamic.
This would be cases where customer expects to get raw data only, but we would like to run QC to get data on success of library prep and sequencing.

@hassanfa
Copy link
Contributor Author

hassanfa commented Nov 9, 2020

So what is the proposed solution?

Temporary solutions:

  1. Find out through production which customers are are only fastq delivery. Example: molecular health
  2. We have fastq delivery (they are not BALSAMIC, MIP, nor microsalt) for some samples. They will all automatically be run through QC workflow.

Do we want to introduce a delivery field in Status to indicate delivery type and handle these cases accordingly?

This exists to some extent. Probably @annagellerbring or @elevu know how it is defined in orders. Maybe even @patrikgrenfeldt can help on order portal side.

@elevu
Copy link

elevu commented Nov 9, 2020

As I understand, now in the order portal for Balsamic there is no way to specify the delivery type. But it definitely can be added.

@hassanfa
Copy link
Contributor Author

hassanfa commented Nov 9, 2020

How about analysis type? Are all analysis only "BALSAMIC" | "MICROSALT" | "FASTQ" | "MIP"?

@Mropat Mropat added the Balsamic Issued related to the Balsamic workflow label Dec 17, 2020
@Mropat Mropat self-assigned this Feb 8, 2021
@henrikstranneheim
Copy link
Contributor

@Mropat What is the status of this? Order portal parts seems to be done, but what is left to do in cg?

@hassanfa
Copy link
Contributor Author

hassanfa commented Mar 9, 2021

This is ancient. Balsamic doesn't have qc only anymore. This can be closed.

@henrikstranneheim
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balsamic Issued related to the Balsamic workflow Effort M Gain M Urgency M
Projects
None yet
Development

No branches or pull requests

5 participants