-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/sdk 3710/support v6.1.0 #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates ct version - Updates compile and targetSDK to 34
* task(SDK-3710) - Upgrades gradle version for example app to 8.2.2. - Updates AGP to 8.2.2 - Updates google-services plugin to 4.4.1 - Updates react-native to 0.73.5 to support AGP 8 - Update react-native-reanimated to resolve build issues - Adds metro.config.js and svg-transformer to resolve build issues - Updates metro.config.js for newer RN version - Updates ndk version for react-native-reanimated error - Delete ReactNativeFlipper.java as required for latest react-native * task(SDK-3710) - Updates AGP for lib * task(SDK-3710) - Resolves build error for lib
CTLalit
reviewed
Mar 5, 2024
CTLalit
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments
@Anush-Shand please update the description to mention update to v6.1.1 |
shivamsharma2710
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CTLalit
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Support For v6.1.1
Also Upgrades Gradle to 8.2.2