Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ocean monster spawns moddable #70366

Closed
LyleSY opened this issue Dec 22, 2023 · 4 comments
Closed

Make ocean monster spawns moddable #70366

LyleSY opened this issue Dec 22, 2023 · 4 comments
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@LyleSY
Copy link
Contributor

LyleSY commented Dec 22, 2023

Is your feature request related to a problem? Please describe.

A couple of new wilderness spawn groups were created for #70202 but it doesn't look like it has the same features that the others have to allow mods to add monsters

Solution you would like.

Give the ocean monster groups the same modding options that the other groups have

Describe alternatives you have considered.

No response

Additional context

Discovered testing #70362

@LyleSY LyleSY added the <Suggestion / Discussion> Talk it out before implementing label Dec 22, 2023
@gkarfakis19
Copy link
Contributor

Hi. I built those mongroups. I am not sure what the issue is here. I am not very familiar with how mods work, but they should be able to change any json file, right?

@LyleSY
Copy link
Contributor Author

LyleSY commented Dec 24, 2023

This has happened a few times and it involves some code work that I don't understand. My sense from talking to others in the past is that there is something called something like a "generic factory" and if groups are added to that, they are then made available for modding, but this is a second separate step and does not happen automatically.

@gkarfakis19
Copy link
Contributor

Hey. A cursory look at the files shows that the newly added mongroups are absolutely no different than any other mongroup I have seen. I can find no mention of them in any generic factory.
What error are you getting precisely? Are the newly defined spawns just straight up not working for you?

Perhaps you can ask around in discord? Someone is bound to know what's happening.

@LyleSY
Copy link
Contributor Author

LyleSY commented Dec 26, 2023

Yep, my test wasn't extreme enough. I rebuilt it and got it working correctly. Thanks!

@LyleSY LyleSY closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

2 participants