Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc-addon-elasticsearch-options: support multiple currencies #1172

Closed
florian-sanders-cc opened this issue Oct 3, 2024 · 0 comments · Fixed by #1325
Closed

cc-addon-elasticsearch-options: support multiple currencies #1172

florian-sanders-cc opened this issue Oct 3, 2024 · 0 comments · Fixed by #1325
Assignees
Labels
breaking-change Something that will required a major semver release enhancement New feature or request

Comments

@florian-sanders-cc
Copy link
Contributor

florian-sanders-cc commented Oct 3, 2024

Context

The cc-addon-elasticsearch-options shows price estimation for Kibana / APM but the currency is hard coded to EUR.

  • Both the price & currency should come from the new authenticated price system endpoint (this is handled by the tunnel creation within the console) => EDIT: maybe not from the price system, the estimation comes from another route.
  • The component should be able to a different currency (this needs to be changed within the component).
@florian-sanders-cc florian-sanders-cc added the enhancement New feature or request label Oct 3, 2024
@florian-sanders-cc florian-sanders-cc added this to the multi-currency milestone Oct 3, 2024
@florian-sanders-cc florian-sanders-cc self-assigned this Oct 3, 2024
@florian-sanders-cc florian-sanders-cc added the breaking-change Something that will required a major semver release label Oct 3, 2024
florian-sanders-cc added a commit that referenced this issue Jan 9, 2025
…led billing

BREAKING CHANGE: the `options` property has been replaced with a `state`
property

- the `options` property & attribute have been removed,
- a `state` property & attribute have been added instead,
  - the `state.type` property can be used to set the component in
    `loading` or `loaded` state,
  - in `loading` state, the component shows skeletons instead of flavor
    info and cost info (if monthly cost is enabled) for APM and Kibana options,
  - the `state.hasMonthlyCost` property can be used to enable / disable
    the display of cost info (enabled by default),
  - the `state.options` can be used to pass options to display,
  - on each option, the `flavor.monthlyCost` can be used to set the
    `amount` and the `currency` to display (`loaded` state only).

Fixes #1172
Fixes #1230
florian-sanders-cc added a commit that referenced this issue Jan 10, 2025
…led billing

BREAKING CHANGE: the `options` property has been replaced with a `state`
property

- the `options` property & attribute have been removed,
- a `state` property & attribute have been added instead,
  - the `state.type` property can be used to set the component in
    `loading` or `loaded` state,
  - in `loading` state, the component shows skeletons instead of flavor
    info and cost info (if monthly cost is enabled) for APM and Kibana options,
  - the `state.hasMonthlyCost` property can be used to enable / disable
    the display of cost info (enabled by default),
  - the `state.options` can be used to pass options to display,
  - on each option, the `flavor.monthlyCost` can be used to set the
    `amount` and the `currency` to display (`loaded` state only).

Fixes #1172
Fixes #1230
florian-sanders-cc added a commit that referenced this issue Feb 10, 2025
…led billing

BREAKING CHANGE: the `monthlyCost` format in `flavor` has changed
- `options[number].flavor.monthlyCost` is now an object with two
  properties:
    - `currency` like 'EUR' or 'USD',
    - `amount` for the actual cost number.

Fixes #1172
Fixes #1230
florian-sanders-cc added a commit that referenced this issue Feb 10, 2025
…led billing

Fixes #1172
Fixes #1230

BREAKING CHANGE: the `monthlyCost` format in `flavor` has changed
- `options[number].flavor.monthlyCost` is now an object with two
  properties:
    - `currency` like 'EUR' or 'USD',
    - `amount` for the actual cost number.
florian-sanders-cc added a commit that referenced this issue Feb 10, 2025
…led billing

Fixes #1172
Fixes #1230

BREAKING CHANGE: the `monthlyCost` format in `flavor` has changed
- `options[number].flavor.monthlyCost` is now an object with two
  properties:
    - `currency` like 'EUR' or 'USD',
    - `amount` for the actual cost number.
florian-sanders-cc added a commit that referenced this issue Feb 18, 2025
…led billing

Fixes #1172
Fixes #1230

BREAKING CHANGE: the `monthlyCost` format in `flavor` has changed
- `options[number].flavor.monthlyCost` is now an object with two
  properties:
    - `currency` like 'EUR' or 'USD',
    - `amount` for the actual cost number.
florian-sanders-cc added a commit that referenced this issue Feb 19, 2025
…led billing

Fixes #1172
Fixes #1230

BREAKING CHANGE: the `monthlyCost` format in `flavor` has changed
- `options[number].flavor.monthlyCost` is now an object with two
  properties:
    - `currency` like 'EUR' or 'USD',
    - `amount` for the actual cost number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Something that will required a major semver release enhancement New feature or request
Projects
None yet
1 participant