diff --git a/library/src/main/java/com/chuckerteam/chucker/internal/ui/MainActivity.kt b/library/src/main/java/com/chuckerteam/chucker/internal/ui/MainActivity.kt index bfa43b160..84e71578f 100644 --- a/library/src/main/java/com/chuckerteam/chucker/internal/ui/MainActivity.kt +++ b/library/src/main/java/com/chuckerteam/chucker/internal/ui/MainActivity.kt @@ -82,7 +82,7 @@ class MainActivity : } override fun onErrorClick(throwableId: Long, position: Int) { - startActivity(ErrorActivity.newInstance(this, throwableId)) + ErrorActivity.start(this, throwableId) } override fun onTransactionClick(transactionId: Long, position: Int) { diff --git a/library/src/main/java/com/chuckerteam/chucker/internal/ui/error/ErrorActivity.kt b/library/src/main/java/com/chuckerteam/chucker/internal/ui/error/ErrorActivity.kt index 38ae72c0e..79f258a38 100644 --- a/library/src/main/java/com/chuckerteam/chucker/internal/ui/error/ErrorActivity.kt +++ b/library/src/main/java/com/chuckerteam/chucker/internal/ui/error/ErrorActivity.kt @@ -15,9 +15,6 @@ import com.chuckerteam.chucker.internal.data.entity.RecordedThrowable import com.chuckerteam.chucker.internal.data.repository.RepositoryProvider import java.text.DateFormat -private const val EXTRA_THROWABLE_ID = "EXTRA_THROWABLE_ID" -private const val TEXT_PLAIN = "text/plain" - internal class ErrorActivity : AppCompatActivity() { private var throwableId: Long = 0 @@ -105,11 +102,14 @@ internal class ErrorActivity : AppCompatActivity() { } companion object { - @JvmStatic - fun newInstance(context: Context, throwableId: Long) = - Intent(context, ErrorActivity::class.java).apply { - putExtra(EXTRA_THROWABLE_ID, throwableId) - } + private const val EXTRA_THROWABLE_ID = "transaction_id" + private const val TEXT_PLAIN = "text/plain" + + fun start(context: Context, throwableId: Long) { + val intent = Intent(context, ErrorActivity::class.java) + intent.putExtra(EXTRA_THROWABLE_ID, throwableId) + context.startActivity(intent) + } } private val RecordedThrowable.formattedDate: String diff --git a/library/src/main/java/com/chuckerteam/chucker/internal/ui/transaction/TransactionActivity.kt b/library/src/main/java/com/chuckerteam/chucker/internal/ui/transaction/TransactionActivity.kt index 1eb11a4f8..600a4870e 100644 --- a/library/src/main/java/com/chuckerteam/chucker/internal/ui/transaction/TransactionActivity.kt +++ b/library/src/main/java/com/chuckerteam/chucker/internal/ui/transaction/TransactionActivity.kt @@ -61,7 +61,7 @@ internal class TransactionActivity : BaseChuckerActivity() { val tabLayout = findViewById(R.id.tabs) tabLayout.setupWithViewPager(viewPager) - transactionId = intent.getLongExtra(ARG_TRANSACTION_ID, 0) + transactionId = intent.getLongExtra(EXTRA_TRANSACTION_ID, 0) } override fun onResume() { @@ -149,14 +149,12 @@ internal class TransactionActivity : BaseChuckerActivity() { } companion object { - - private const val ARG_TRANSACTION_ID = "transaction_id" + private const val EXTRA_TRANSACTION_ID = "transaction_id" private var selectedTabPosition = 0 - @JvmStatic fun start(context: Context, transactionId: Long) { val intent = Intent(context, TransactionActivity::class.java) - intent.putExtra(ARG_TRANSACTION_ID, transactionId) + intent.putExtra(EXTRA_TRANSACTION_ID, transactionId) context.startActivity(intent) } }