-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state for empty screens #276
Comments
Totally agree. Ideally having some graphic would be helpful. Maybe some Vector Drawable to do not impact on the library size. Otherwise just text would work fine. |
Yes, I thought about drawable as well. Actually, I already picked one. Here is an example The problem with implementation of such state is in fact that with the current logic in TransactionPayloadFragment's AsyncTask we are transaction items into a |
I'd go for something more positive if possible (like this https://materialdesignicons.com/icon/package-variant). I personally considered the neutral face to inform that something hasn't really worked as expected but that's no big deal (like a failure that is not preventing the app from working). Also please note that the majority of the HTTP requests (GETs) are without request body, so that icon will be shown a lot of times. But that's just my personal taste. Agree to let #270 and #259 go over this (this is a nice to have imho). |
Your option is great actually. Overlooked an empty package icon when tried to pick something for this purpose. |
Currently Chucker shows no difference between a request with empty body and a request which somehow failed to fetch info to display. States should be distinct, so user could understand what is going on.
💡 Describe the solution you'd like
In cases where the request/response is really empty we should show some state telling user that there is an empty request/response.
📄 Additional context
Here is how empty state looks now
🙋 Do you want to develop this feature yourself?
The text was updated successfully, but these errors were encountered: