Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response Search Improvements #151

Open
1 of 2 tasks
kmayoral opened this issue Oct 29, 2019 · 10 comments
Open
1 of 2 tasks

Response Search Improvements #151

kmayoral opened this issue Oct 29, 2019 · 10 comments
Assignees
Labels
feature request Request a new feature to be developed work-in-progress This Issue/PR is currently under development

Comments

@kmayoral
Copy link
Contributor

⚠️ Is your feature request related to a problem? Please describe.

One related problem is that when you perform a search in the response tab, any highlighted matches will be unhighlighted as you scroll through the body of the response. Furthermore, the act of searching does not auto scroll to the first occurrence of the search result as I would expect.

🎯 Describe the solution you'd like

I propose the following:

  • As you type a search query, the body should auto scroll to the first occurrence of the search term
  • Proper highlighting be maintained for search results as you scroll through the body of the response
  • Additional search controls be introduced to allow for navigating between next and previous search results with additional meta data displaying the current visited search result index and the total count of search results shown.

📊 Describe alternatives you've considered

No other alternatives considered at this time

📄 Additional context

Thanks for a great product and for your consideration of this request.

📝 Do you want to develop this feature yourself?

  • Yes
  • No
@cortinico cortinico added the feature request Request a new feature to be developed label Nov 4, 2019
@cortinico
Copy link
Member

cortinico commented Nov 4, 2019

Sounds like a great idea :) This is open for development if someone wants to pick it up

@vbuberen
Copy link
Collaborator

vbuberen commented Nov 6, 2019

I would like to try to implement it in about 2 weeks when I have more time.
If someone can do it earlier - please, leave a note here, so I will be aware of it.

@vbuberen
Copy link
Collaborator

vbuberen commented Nov 6, 2019

Also, I am not sure if this feature should go into 3.1.0 release, since it already has pretty serious amount of changes. @cortinico Agree?

@cortinico
Copy link
Member

Yeah, let's push it to 3.2.x or further.

@vbuberen
Copy link
Collaborator

Moving further to be able to release 3.2.0

@vbuberen
Copy link
Collaborator

Update here - I am on it and going to present the solution pretty soon
Here is a sneak peak of how the UI would look like during the search (that view for navigating will also have number of occurrences and number of the currently selected one:
Screenshot 2020-03-30 at 15 54 57

@vbuberen vbuberen removed this from the 3.2.0 milestone Mar 30, 2020
@JFalky
Copy link

JFalky commented Jun 3, 2022

Hello! I'm really looking forward to this feature. How quickly can you complete it? =)

@ArjanSM
Copy link
Contributor

ArjanSM commented Feb 13, 2023

@vbuberen may I be of any help for finishing this feature?

@vbuberen
Copy link
Collaborator

I am not working on it for quite a long time already as switched to Flutter development and lost motivation for it.
So it is free to grab.

@cortinico
Copy link
Member

@vbuberen may I be of any help for finishing this feature?

I've assigned this to you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a new feature to be developed work-in-progress This Issue/PR is currently under development
Projects
None yet
Development

No branches or pull requests

5 participants