Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1, drop 7.3 #14

Closed
korelstar opened this issue Jan 30, 2022 · 5 comments · Fixed by #15
Closed

Support PHP 8.1, drop 7.3 #14

korelstar opened this issue Jan 30, 2022 · 5 comments · Fixed by #15
Labels
enhancement

Comments

@korelstar
Copy link
Contributor

As far as I can see, Nextcloud 24 will support PHP 8.1 - at least the master branch has support for it: nextcloud/server@72baee9

However, this composer package does not support PHP 8.1 yet. Please add support for it and publish it :-)
@korelstar korelstar mentioned this issue Jan 30, 2022
Merged
@ChristophWurst
Copy link
Owner

Makes sense! Could you send a PR please?

@ChristophWurst
Copy link
Owner

7.3 should also be dropped as per nextcloud/server#29286

@ChristophWurst ChristophWurst changed the title Support PHP 8.1 Support PHP 8.1, drop 7.3 Feb 2, 2022
@korelstar
Copy link
Contributor Author

Sorry, I'm not aware on how this repository works. Honestly, I have no idea where to do such a change and how to publish a new version. Maybe you could do it?

@ChristophWurst
Copy link
Owner

No worries.

nextcloud_composer/composer.json

Line 13 in 07ca35f

"php": "^7.3 || ~8.0.0",
is the only line that needs change. I'll take care of the release.

@korelstar korelstar mentioned this issue Feb 6, 2022
Merged
@ChristophWurst
Copy link
Owner

https://packagist.org/packages/christophwurst/nextcloud#dev-master can be used with 8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support PHP 8.1, drop 7.3
2 participants
@ChristophWurst @korelstar