-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemReady state when changing e.g. room config and other events firing too often #28
Comments
This is not an inteded behaviour. |
@Alex9779 |
I played with your server too recently and had it still but not always. Mostly when adding or removing rooms from a zone. |
Ok just as a base info I have three Raumfeld One S in three different rooms, names 'Kiara', 'Küche' and 'Julian' and one Raumfeld Soundbar in 'Wohnzimmer'.
|
At the very top you can see that the zone changes but then also the connection to the server is terminated and everything is read from the start and because all connection to the server are dropped the system goes to 'not ready'... |
after some tests i can confirm the issue. I am not sure yet why it happens. |
I found a bug in the node-raumkernel in lib.manager.deviceManager. @Alex9779 EDIT: git and NPM is up to date. Would you be so nice to check the fix? |
Ya cool will test when got some time and I can use the system for testing... |
Ok seems this is fixed, couldn't get the error again not matter what I do... |
I just started testing how I can use your raumkernel for implementing nodes for node-red to control several aspects of my raumfeld system with node-red in connection with MQTT and homebridge and Apple Home.
It works so far but when I monitor some of the core events, on top the systemReady event, I always get all the stuff I expect when I first connect to a system like systemReady and host found and renderers found when I change the config of my system with the normal iOS app.
Is that an intended behaviour?
Because this seems not really right to me. When I monitor the systemReady state and I remove a speaker from a zone then the system is not ready and then ready again and all the renderers are rediscovered. This makes it hard to bind action to those events because they are triggered too often.
I thought this was because of my noob implementation of my first node, just started using js and node and that stuff. But then I tried just the test.js you provide and this does all the same I see with my implementation: events firing when I just remove a speaker to a zone or remove it it seems the whole kernel sets back as if it just connected again to the host...
The text was updated successfully, but these errors were encountered: