Plugin settings: bug on checkbox with default=true (frontend)

[JohnXLivingston]

Describe the current behavior

If a plugin has a checkbox settings with default value true, then the frontend always receive true as value.

I think that this is the line in cause:

PeerTube/server/models/server/plugin.ts

Line 286 in 3cf8874

result[r.name] = settings[r.name] || r.default || null

It should test if the key is in settings, not the value.

We had a similar bug on the backend ( #3838 ), here it is for the frontend.

Steps to reproduce:

1. Use a plugin with a checkbox settings value defaulting to true
2. Uncheck the checkbox
3. The frontend gets true as value

• PeerTube instance:
  • version: all version, including 3.2.0-rc1

[JohnXLivingston]

Just made a PR to fix this.

[Chocobozzz]

Fixed by #4107