Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Side Effects When backtracking in a CstParser #789

Closed
bd82 opened this issue Jul 21, 2018 · 3 comments
Closed

Unexpected Side Effects When backtracking in a CstParser #789

bd82 opened this issue Jul 21, 2018 · 3 comments

Comments

@bd82
Copy link
Member

bd82 commented Jul 21, 2018

Is the CST created for a backtracked rule ignored? or are there side effects from building the CST
and "rewinding" after back tracking?

@bd82
Copy link
Member Author

bd82 commented Nov 19, 2018

It seems that it does because the cstPostNonTerminal method does not take it int account.

There are more things to consider here:

  • Should backtracking disable CST building completely or just the side effects.
    • Without the partial CST results some grammars (that reflect on the CST and modify GATES) may break.
    • But in other cases the CST is completely redundant while backtracking so avoiding its creation would improve performance.

@bd82
Copy link
Member Author

bd82 commented Jan 16, 2019

@bd82
Copy link
Member Author

bd82 commented Sep 10, 2019

What are the performance implications for fixing this?

@bd82 bd82 changed the title Investigate: Does backtracking conflict with automatic CST creation? Unexpected Side Effects When backtracking in a CstParser Sep 12, 2019
@bd82 bd82 closed this as completed in 1dc658e Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant