Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type issue in gkmx() #3

Open
ChenhanYu opened this issue Nov 3, 2016 · 0 comments
Open

Type issue in gkmx() #3

ChenhanYu opened this issue Nov 3, 2016 · 0 comments
Assignees
Labels

Comments

@ChenhanYu
Copy link
Owner

/frame/gkmx.hpp

Notice that currently gkmx<...,TA,TB,TC,TV> has the following issues.

  1. TV cannot be different from TC.
  2. Type rules in macro kernels may be wrong.

According to the definition, gkmx only need to pass in an m-by-n of C in type TC, but when k > KC the temporary rank-KC update must be stored as an m-by-NC matrix as type TV. It it very unpleasant to allocate this temporary buffer, but currently I have not find a way to resolve this. GKRM will have the same issue later.

Maybe we can increase KC such that k will never be larger than KC when TC != TV detected.

Notice that gkmx_gpu.hpp does not have this problem. GEMM algorithm on GPU does not store rank-KC update back to the global memory. L1 cache on GPU can be manually controlled; thus, storing back in unnecessary.

@ChenhanYu ChenhanYu added the bug label Nov 3, 2016
@ChenhanYu ChenhanYu self-assigned this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant