Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings test still failing #1061

Closed
Tbaut opened this issue May 28, 2021 · 1 comment
Closed

Settings test still failing #1061

Tbaut opened this issue May 28, 2021 · 1 comment
Assignees
@Tbaut
Labels
Priority: P1 High Added to issues relating to a high severity bugs. Testing Added to issues to signal that it is part of an epic Type: Bug Fix Added to PRs if they are addressing a bug

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented May 28, 2021

Despite #1055 and #1054 the settings test still randomly fails.
The viewport change seems to be triggered too early, and we should give a shot at using it in a beforeAll
@Tbaut Tbaut added Priority: P1 High Added to issues relating to a high severity bugs. Type: Bug Fix Added to PRs if they are addressing a bug Testing Added to issues to signal that it is part of an epic labels May 28, 2021
@Tbaut Tbaut self-assigned this May 28, 2021
@Tbaut Tbaut mentioned this issue May 28, 2021
Merged
@Tbaut
Copy link
Collaborator Author

Tbaut commented May 31, 2021

replaced by #1070

@Tbaut Tbaut closed this as completed May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tbaut Tbaut

Labels
Priority: P1 High Added to issues relating to a high severity bugs. Testing Added to issues to signal that it is part of an epic Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tbaut