Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable compliance tests #283

Open
wemeetagain opened this issue Jun 15, 2022 · 2 comments
Open

Re-enable compliance tests #283

wemeetagain opened this issue Jun 15, 2022 · 2 comments
Labels
prio-low

Comments

@wemeetagain
Copy link
Member

Compliance tests currently break due to overly-restrictive expectation of registrar.register being called once in start and registrar.unregister being called once in stop.

We register up to 3 protocols, not just a single one. (gossipsub v1.1, gossipsub v1.0, floodsub)
@wemeetagain wemeetagain mentioned this issue Jun 15, 2022
Merged
@dapplion
Copy link
Contributor

@wemeetagain Is this done?

@wemeetagain
Copy link
Member Author

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wemeetagain @dapplion @philknows