You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A-blockedissue or PR is blocked until something else changes.C-simpleMinor changes changes, no additional research needed. Good first issue/review.S-grandpaissues related to block finality.
While syncing Gossamer faces the following problem:
2023-11-30T13:58:45Z ERROR block data processing for block with hash 0xb9b61c899c864d69a20a2f3abad55825f51ff09b493100dce632033c12a27014 failed: checking if descendant of highest block: getting header: pebble: not found pkg=sync
This problem happened after we changed the flow of importing blocks through sync (fix(dot/sync): verify justification before importing blocks #3576), basically, we only insert the block in the tree and execute it if its justification is valid otherwise we discard it.
With this change, the function VerifyBlockJustification doesn't work properly because when it checks if a block belongs to the highest finalized chain. It requires that the block being verified is in the block tree, otherwise, it returns that cannot get the block header
To fix this problem we should make sure that this function doesn't depend on blocks in the block tree and change it to verify blocks that were acquired through sync
The text was updated successfully, but these errors were encountered:
EclesioMeloJunior
added
C-simple
Minor changes changes, no additional research needed. Good first issue/review.
A-blocked
issue or PR is blocked until something else changes.
P-high
this should be addressed ASAP.
S-grandpa
issues related to block finality.
labels
Jan 17, 2024
A-blockedissue or PR is blocked until something else changes.C-simpleMinor changes changes, no additional research needed. Good first issue/review.S-grandpaissues related to block finality.
Describe the bug
This problem happened after we changed the flow of importing blocks through sync (fix(dot/sync): verify justification before importing blocks #3576), basically, we only insert the block in the tree and execute it if its justification is valid otherwise we discard it.
With this change, the function
VerifyBlockJustification
doesn't work properly because when it checks if a block belongs to the highest finalized chain. It requires that the block being verified is in the block tree, otherwise, it returns that cannot get the block headerTo fix this problem we should make sure that this function doesn't depend on blocks in the block tree and change it to verify blocks that were acquired through sync
The text was updated successfully, but these errors were encountered: