Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifyBlockJustification fails to assert ancestry of blocks not in the BlockTree #3613

Closed
EclesioMeloJunior opened this issue Nov 30, 2023 · 2 comments
Labels
A-blocked issue or PR is blocked until something else changes. C-simple Minor changes changes, no additional research needed. Good first issue/review. S-grandpa issues related to block finality.

Comments

@EclesioMeloJunior
Copy link
Member

Describe the bug

  • While syncing Gossamer faces the following problem:
2023-11-30T13:58:45Z ERROR block data processing for block with hash 0xb9b61c899c864d69a20a2f3abad55825f51ff09b493100dce632033c12a27014 failed: checking if descendant of highest block: getting header: pebble: not found pkg=sync
  • This problem happened after we changed the flow of importing blocks through sync (fix(dot/sync): verify justification before importing blocks #3576), basically, we only insert the block in the tree and execute it if its justification is valid otherwise we discard it.

  • With this change, the function VerifyBlockJustification doesn't work properly because when it checks if a block belongs to the highest finalized chain. It requires that the block being verified is in the block tree, otherwise, it returns that cannot get the block header

  • To fix this problem we should make sure that this function doesn't depend on blocks in the block tree and change it to verify blocks that were acquired through sync

@EclesioMeloJunior EclesioMeloJunior self-assigned this Nov 30, 2023
@P1sar P1sar removed Sync labels Jan 15, 2024
@EclesioMeloJunior EclesioMeloJunior added C-simple Minor changes changes, no additional research needed. Good first issue/review. A-blocked issue or PR is blocked until something else changes. P-high this should be addressed ASAP. S-grandpa issues related to block finality. labels Jan 17, 2024
@P1sar
Copy link
Member

P1sar commented Jan 18, 2024

@EclesioMeloJunior please add issue that blocks this.

@P1sar P1sar assigned timwu20 and unassigned EclesioMeloJunior Jan 18, 2024
@P1sar P1sar removed the P-high this should be addressed ASAP. label Jan 18, 2024
@P1sar
Copy link
Member

P1sar commented Jan 18, 2024

@EclesioMeloJunior please remove duplicate #3468

@P1sar P1sar closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blocked issue or PR is blocked until something else changes. C-simple Minor changes changes, no additional research needed. Good first issue/review. S-grandpa issues related to block finality.
Projects
None yet
Development

No branches or pull requests

3 participants