-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trie: store value of nodes on disk #2323
Comments
#2340 should remove the need for this, let's hold for now. |
@qdm12 is this still needed? seems like the memory issue is fine now |
Ehhh, I still need to finish #2310 to know how many nodes we have in memory. In the long run, the node goes out of memory after a few weeks, so this may be needed. Let's keep this opened until we're sure the trie isn't a cause for memory increasing in the long run. |
This is no longer needed, having the whole state trie (and deltas from forks before finalization) does not use much memory (~100MB at the tip). See #1973 for an update on memory usage. |
Task summary
If #2321 and #2322 do not solve the memory usage issue, this should be worked on.
For now we keep the value of each node of the trie in memory.
We should instead write the nodes values to disk and fetch it from disk when needed.
This will cause a potential speed performance degradation (to verify), but can be a major cause for extreme memory usage.
The text was updated successfully, but these errors were encountered: