Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/mod.rs is weird and should probably be removed #3324

Closed
aatifsyed opened this issue Aug 4, 2023 · 3 comments · Fixed by #3325
Closed

src/mod.rs is weird and should probably be removed #3324

aatifsyed opened this issue Aug 4, 2023 · 3 comments · Fixed by #3325

Comments

@aatifsyed
Copy link
Contributor

//! This module contains code that is shared between the library and the build script

Which isn't true - it's only referenced in the build script. It should move out of src.

@hanabi1224
Copy link
Contributor

@aatifsyed It is used in test_load_actor_bundles and I did plan to move some shared CAR concat util functions into it : )

@aatifsyed
Copy link
Contributor Author

forest/src/lib.rs

Lines 53 to 55 in 77d6b2b

pub mod build {
pub use super::r#mod::*;
}

!

@hanabi1224
Copy link
Contributor

#3325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants