Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache multiple zstd frames in CompressedCarV1BackedBlockstore #3207

Closed
aatifsyed opened this issue Jul 17, 2023 · 3 comments
Closed

Cache multiple zstd frames in CompressedCarV1BackedBlockstore #3207

aatifsyed opened this issue Jul 17, 2023 · 3 comments

Comments

@aatifsyed
Copy link
Contributor

We currently only cache one zstd frame:

most_recent_zstd_frame: Option<(u64, std::io::Cursor<Vec<u8>>)>,

But

executing tipsets is roughly 5x slower with compressed snapshots than without on my machine. A cache of decoded frames should close that gap, though.

We should cache more frames and see if that helps.

@creativcoder creativcoder self-assigned this Jul 18, 2023
@lemmih
Copy link
Contributor

lemmih commented Jul 18, 2023

Note that we eventually want multiple CAR files sharing a single cache.

@lemmih
Copy link
Contributor

lemmih commented Jul 18, 2023

It doesn't make sense to work on this until the CAR store has matured. Otherwise, it'll just have to be rewritten.

@lemmih
Copy link
Contributor

lemmih commented Jul 31, 2023

Closed by #3288

@lemmih lemmih closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants