Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy Lint Ignore #1065

Closed
ec2 opened this issue Mar 29, 2021 · 2 comments
Closed

Fix Clippy Lint Ignore #1065

ec2 opened this issue Mar 29, 2021 · 2 comments
Labels
Maintenance

Comments

@ec2
Copy link
Member

ec2 commented Mar 29, 2021

Issue summary

Currently we are disabling clippy::upper_case_acronyms in the CI and Makefile. This is because to fix these would require new crate releases on a bunch of different crates. So I've decided to just ignore those new linting rules and fix them the next time we need to release new crates.

Other information and links
@cryptoquick
Copy link
Contributor

I'm not sure we'll ever get to this, or if we'll find a reason to get to this. I'd be in favor of closing the issue.

@q9f
Copy link
Contributor

q9f commented Jan 12, 2022

fixed in #1236 #1237 #1238 and #1239

@q9f q9f closed this as completed Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cryptoquick @ec2 @q9f