Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCellID API key is not immediately displayed #837

Closed
agilob opened this issue Apr 5, 2016 · 11 comments
Closed

OpenCellID API key is not immediately displayed #837

agilob opened this issue Apr 5, 2016 · 11 comments
Labels

Comments

@agilob
Copy link
Contributor

agilob commented Apr 5, 2016

EDIT by SecUpwN: @agilob, we have implemented Issue Templates for a reason! Please use it!


Description of Issue: After saving the new OCID API key, it does not show immediately in the field OpenCellID API Key. It is empty. Only after exiting the Settings and re-entering that field the key is shown. The way it should work is that it is immmediately shown when pressing that button after fetching it.

@mimi89999
Copy link
Collaborator

@agilob Exit AIMSICD. Reopen AIMSICD and check if the key has appeared.

@agilob
Copy link
Contributor Author

agilob commented Apr 5, 2016

Activity should listen for changes in shared preferences and update text field with the key, it has nothing to do with restarting application.

@Nordlenning
Copy link
Member

The strange is that Key is downloaded & accepted since you can download OICD data without restarting the app, it's not displayed in the key requester until you restart the app.
OCID data gets downloaded.

@agilob
Copy link
Contributor Author

agilob commented Apr 5, 2016

it's not displayed in the key requester until you restart the app.

No need to restart the app! Just restart preferences activity and the key is there.

@SecUpwN
Copy link
Member

SecUpwN commented Apr 5, 2016

No need to restart the app! Just restart preferences activity and the key is there.

So I guess the way it should work is that the key is shown immediately after it has been fetched?

@SecUpwN SecUpwN changed the title After saving new OCID API key I tried to edit it, but the text field is empty OpenCellID API key is not immediately displayed Apr 5, 2016
@SecUpwN SecUpwN added the bug label Apr 5, 2016
@agilob
Copy link
Contributor Author

agilob commented Apr 5, 2016

Yes, that's the expected behaviour.

@Nordlenning
Copy link
Member

This seems to be fixed in v0.1.43-alpha
OpenCellID API key is immediately displayed on my phone.

@agilob
Copy link
Contributor Author

agilob commented May 6, 2016

  1. Uninstall AIMSICD
  2. Install AIMSICD
  3. Go to Settings
  4. Request OCID
  5. New bug, after successful request where API key was saved window with 'requesting key' is not closed...
  6. Press back
  7. Edit OCID API key
  8. Field is empty

No, there are two bugs now there.

@SecUpwN
Copy link
Member

SecUpwN commented May 7, 2016

@agilob, the main Issue I have with your bug reports is that you are not using the bleeding edge work. Please make sure to compile our development branch before telling that a bug still exists. Thank you!

@agilob
Copy link
Contributor Author

agilob commented May 7, 2016

lol I'm not falling into this again.

@Nordlenning
Copy link
Member

UnwiredLabs do not offer random OCID API key so this could be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants