Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load cells in range on map #466

Closed
wvengen opened this issue Jun 13, 2015 · 10 comments
Closed

Only load cells in range on map #466

wvengen opened this issue Jun 13, 2015 · 10 comments

Comments

@wvengen
Copy link
Contributor

wvengen commented Jun 13, 2015

Currently all cells are loaded from the database and shown on the map view. This takes a lof of time when there are many cell points (ike from OCID). I suggest to add a where clause to the database query on a lat/lng window, and re-query when changing the view.

I can imagine that #272 would be solved by this as well.

@E3V3A
Copy link
Contributor

E3V3A commented Jun 13, 2015

The problem with "range" is that it could mean anything. Your phone could connect to towers 40+ km away... Not sure what to do here, but I guess once #215, #303 and subsequently #250 has been implemented it would be easier to deal with distant cells outside the view box.

@wvengen
Copy link
Contributor Author

wvengen commented Jun 13, 2015

True. Though I fail to see why that would be an issue when showing the map - cells outside the view aren't shown anyway, right?

@SecUpwN
Copy link
Member

SecUpwN commented Jun 14, 2015

Though I fail to see why that would be an issue when showing the map - cells outside the view aren't shown anyway, right?

Right. I added you to our Buildozer account to get the APK for testing. Please test and close if fixed.

@wvengen
Copy link
Contributor Author

wvengen commented Jun 14, 2015

Thanks! I found it to be ok on the branch I was working on (local build), but I'll test again with the new APK.

@wvengen
Copy link
Contributor Author

wvengen commented Jun 14, 2015

Works!

@wvengen wvengen closed this as completed Jun 14, 2015
@E3V3A
Copy link
Contributor

E3V3A commented Jun 14, 2015

Which build are you using? The latest I just tested # 137 (issue #469) crashed, and Travis-CI shows failed build, so please state what you've tested and so on.

@E3V3A E3V3A reopened this Jun 14, 2015
@SecUpwN
Copy link
Member

SecUpwN commented Jun 16, 2015

@E3V3A, if #469 is now fixed for you and the latest build works, please test and close this. Thanks.

@E3V3A
Copy link
Contributor

E3V3A commented Jun 24, 2015

Unfortunately the side-effect of this PR is that the map view is wrong, laggy and unresponsive until DB query is updated. Not good.

@wvengen
Copy link
Contributor Author

wvengen commented Jul 10, 2015

This will also be reverted in #541.

@E3V3A
Copy link
Contributor

E3V3A commented Jul 14, 2015

Please re-test this issue now. (Using Buildozer build >= 211)

@E3V3A E3V3A closed this as completed Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants