-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mozilla Location Services (MLS) support #446
Comments
Question-1: Will we need any kind of ranking algorithm between OCID vs MLS data, or just use both data sources and combine them if the user requests? Question-2: How can we detect maliciously cells that are purposefully added to these databases? is there any technical way until the cells do something suspicious? [Edited for readability] |
@ph0t0n, this is actually something I'd like to know as well
Still to be solved with #411. Seems like the OCID team is working hard on this as well. |
Q-1: No, yes, exactly as in OP. Q-2: We can't which is the reason for above. But we can detect in several ways by implementing #230. |
Deal. Do we need to add anything else other than already existing support for Local-GSM-Backend? |
This issue is not about LGB support, but about MLS. (open new issue for that.) So yes, we need to add MLS and fix the stuff that was broken due to faulty LGB implementation, i.e. #470. |
LGB does NOT support querying MLS. But an backend for (online) querying MLS also exists: If we are able to switch to request the Cell IDs from LGB over any type of UnifiedNlp API we could use the same API for the MLS backend. In any other case we need a new and different solution to request the Cell IDs from MLS, as it does not have any database file. |
Cleaned up this thread. We need work on implementing the MLS support for the BTS downloader. Adding |
In spare time I was contributing to n76/Local-GSM-Backend, if you want I can add intent-based API to retrieve and provide information about locally saved cells. |
Re-opening this to see what @hannosch has to say about how to best implement support for MLS. |
I'm not sure what exactly you want to do with MLS (and what has been done already). If you want to store the MLS data locally and query it offline, the files are available at https://location.services.mozilla.com/downloads in the same format as OCID. Though uncompressed these are above one gigabyte in size. If you want to use the online query API, the API documentation lives at https://mozilla.github.io/ichnaea/api/geolocate.html these days. I'm pretty sure I gave you an API key in the past. If you want to contribute data back to the service, there's also the submission API at https://mozilla.github.io/ichnaea/api/geosubmit2.html With libstumbler and the microG unifiedNLP library (https://wiki.mozilla.org/CloudServices/Location/Software#Android) there are also two existing libraries that do the work for you. |
Nice idea. Any progress on this? Also note that MLS already includes opencellid so adding both would be redundant. |
We should definitely consider looking at MLS, maybe even as a replacement, since as @rugk says it contains OCID data. My suggestion is because OCID's API is slow, times out, and goes down sometimes. I haven't been able to download from OCID's Web API today |
@f3ndot, thanks for the proposal. If we replace
Before we change to |
I don't know. At least they could easily do it as the data is public domain. |
Hanno from MLS here: As of last week OpenCellID now also includes the cell data from MLS. We have bidirectional sharing of the aggregate cell data finally working. The two projects do differ in their handling of raw observation data. OpenCellID releases those publicly, while we think this is too much of a privacy / tracking problem on the MLS side. It should be up to each user to decide which of those two (or both) projects they want to contribute to. |
The MLS leaderboard in its current form is being retired and replaced by a new one which is going to be specific to our own Stumbler application. It will require signing up with real accounts (Firefox Accounts). While there is an API and other apps could use the new leaderboard, it focuses on individual users, not promoting apps. If your software uses MLS, we'll put it on the list at https://wiki.mozilla.org/CloudServices/Location/Software |
@hannosch, since our app has had so many troubles with |
@j4s0nmchr1st0s, what do you mean? Please clarify. |
@SecUpwN I'm more than happy for your app to switch to MLS. Unfortunately I don't know of any Android developers to help in such an effort. I can answer some questions, but since I'm not an Android or even Java developer myself, I can't help with the code directly. |
That is the thing with ALPHA apps. Heavy lifting with too few contributors and too many complaints.
True. But that is the case with any other WIP project as well. We're currently also mving to yet another type of database so that developers will have an easier life. And making them enjoy the project is key.
We? Who is "we"? This is your second post on our repository. Please help us instead of moaning. ;-) |
@hannosch sorry, but I'm not sure if we're on the same page. AIMSICD doesn't need to know location of user after the request. What it needs is data about cell, let's say I send a request about cell id 12345, expected response that would be helpful in the project is: I just checked MLS api and all it provides, is lat/lon of BTS after quite detailed request (not providing signal strength results in "invalid request" |
I'm not sure how you got the parse error, if I do a "simple" request for a single cell network:
I get back:
For cell requests all fields should be optional, except for the five fields to uniquely identify a cell network. Now the result this gives back is where we think a user is, when they see this cell network. That's subtly different from where the actual cell tower is. For the most part OCID and MLS do the same thing here and use (weighted) averages over all observations to calculate the cell networks estimated position. I didn't comment on this, as both projects give you the same thing. Neither claims to know where the cell tower or antenna is. The only exception to that is a minority of the OCID dataset, which is marked in their download file with the "changeable" column set to 0. On the MLS side we don't have an online API to access more metadata about any of the cell networks. If you absolutely require this, you can use our CSV file downloads of the entire data set. Those include creation and modification times as well as sample numbers. The format for this is the same as that used by OCID (https://mozilla.github.io/ichnaea/import_export.html). |
I just wanted to get you example request... and it worked. Looks like my bad, sorry about that. Regarding the metadata, in such situation MLS becomes irrelevant here, the only thing it "could be useful" would be just to confirm if CID exists at all. But as MLS and OCID contain the same data, AIMSICD already has code to check if CID exists in OCID data. I think this issue can be closed (and "bug" label removed, as it's not a bug). |
Issue: This is not an issue, but would be a great improvement to the flexibility of our BTS data sources.
We are currently depending on the OpenCellID (OCID) DB to obtain the BTS info we need for our detection. This data is used to populate the DBe table. However, Mozilla Location Services (MLS) is now mature, detailed and large enough for us to benefit from their carefully curated data. It is maintained on GitHub as ichnaea.
We already have a very long issue thread in issue #71. It is too long and not enough specific, which is why this issue is created. We already have much of the framework for getting data, so we need to add a setting as in this comment:
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: