Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing ECI because of cutoff issue #128

Closed
zhongpc opened this issue May 21, 2021 · 1 comment
Closed

missing ECI because of cutoff issue #128

zhongpc opened this issue May 21, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@zhongpc
Copy link
Contributor

zhongpc commented May 21, 2021

 max_lp = max(exp_struct.lattice.abc) / 2 
        for size, diameter in sorted(cutoffs.items()):
            new_orbits = []
            neighbors = exp_struct.get_sites_in_sphere([0.5, 0.5, 0.5],
                                                       diameter + max_lp,
                                                       include_index=True)

get neighbors in [0.5,0.5,0.5] with a max_lp can potentially miss the interactions with the centroid. For example, four-anion interactions on a tetrahedra.

To resolve this issue, by changing max_lp = max(exp_struct.lattice.abc) / 2 into max_lp = max(exp_struct.lattice.abc) would work.

This gives exactly the same correlation function as pyabinitio. (More general tests all also welcomed)

@zhongpc zhongpc added the bug Something isn't working label May 21, 2021
@zhongpc zhongpc closed this as completed May 21, 2021
@zhongpc zhongpc reopened this May 21, 2021
@zhongpc zhongpc closed this as completed May 21, 2021
@zhongpc zhongpc reopened this May 21, 2021
@lbluque
Copy link
Collaborator

lbluque commented May 21, 2021

This is the same as #104. Closing this one to have only one conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants