Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated on PHP 8.1 #1256

Closed
ensimo opened this issue Dec 19, 2021 · 3 comments
Closed

Deprecated on PHP 8.1 #1256

ensimo opened this issue Dec 19, 2021 · 3 comments
Assignees
Labels

Comments

@ensimo
Copy link

ensimo commented Dec 19, 2021

Describe the bug

Deprecated: Return type of _HumbugBox87c495005ea2\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///cecil.phar/.box/src/RequirementCollection.php on line 15

Deprecated: Return type of _HumbugBox87c495005ea2\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///cecil.phar/.box/src/RequirementCollection.php on line 19

To reproduce

  • PHP 8.1
  • Cecil 5.79.7
docker run -it --rm php:8.1-cli bash -c "curl -LO https://cecil.app/cecil.phar && chmod +x cecil.phar && ./cecil.phar new:site"

Same on macOS with PHP 8.1.1 (cli) (built: Dec 17 2021 22:38:05) (NTS)

Expected behavior

No Deprecated messages

Version

5.79.7

Operating System

No response

Relevant log output

No response

@ensimo ensimo added the bug label Dec 19, 2021
@ArnaudLigny ArnaudLigny self-assigned this Dec 19, 2021
@ArnaudLigny
Copy link
Member

Hello @ensimo, thanks for your report.

I'm working on a new release to support PHP 8.x, but this is a problem with the way I build PHAR: box-project/box#562. The PR to fix it (box-project/box#578) is already in progress.

I'm waiting :-)

@ArnaudLigny ArnaudLigny moved this to In Progress in Cecil Jul 23, 2022
@ArnaudLigny
Copy link
Member

Work in progress (finally) : the last beta (6.0.0-beta.6) is now working with PHP 8.1 (and PHP 8.2).

While waiting for the stable release (certainly tomorrow), you can test the preview via:

cecil self-update --preview

@ArnaudLigny
Copy link
Member

Hello @ensimo, Cecil finally support PHP 8.1+ with the last release 🥳

cecil self-update

Repository owner moved this from In Progress to Done in Cecil Aug 6, 2022
@ArnaudLigny ArnaudLigny moved this from Done to Released in Cecil Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants