Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example seems to generate null instead of date.between #74

Closed
ghost opened this issue Dec 5, 2020 · 2 comments
Closed

Example seems to generate null instead of date.between #74

ghost opened this issue Dec 5, 2020 · 2 comments
Assignees
@sgobotta
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Dec 5, 2020

Describe the bug
Example seems to generate null instead of date.between:

"publicationDate": {
        "type": "faker",
        "value": "date.between",
        "options": ["2019-01-02", "2019-12-29"]

To Reproduce
Steps to reproduce the behavior:

  1. Execute the example provided by fake-data-generator
  2. The field "publicationDate" is always null

Expected behavior
dates should be generated randomly between both dates
@sgobotta sgobotta self-assigned this Dec 10, 2020
@sgobotta
Copy link
Member

Thanks for letting me know, @JoseGascon !

Looks like we've been giving the same treatment to Object and Array type options parameter from raw .json models.

I'll be addressing a PR with a fix.

@sgobotta sgobotta added the bug Something isn't working label Dec 10, 2020
@sgobotta sgobotta mentioned this issue Dec 10, 2020
Merged
10 tasks
@sgobotta
Copy link
Member

sgobotta commented Dec 10, 2020 •
edited
Loading

Release published under v0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgobotta sgobotta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgobotta