Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't build on any Ubuntu newer than 21.04 #7

Open
ptrxyz opened this issue Aug 1, 2022 · 3 comments
Open

Won't build on any Ubuntu newer than 21.04 #7

ptrxyz opened this issue Aug 1, 2022 · 3 comments

Comments

@ptrxyz
Copy link

ptrxyz commented Aug 1, 2022

Sadly this does not work on Ubuntu 21.10 on wards. I assume it's because Ubuntu 21.10 (impish) installed libc6 (glibc) 2.34, which introduced a major ABI change. SIGSTKSZ is now no longer constant, and can’t be used directly to define array sizes.

I used Ubuntu 21.10, Boost libraries 1.74 and GCC9.

some excrept from the logs:
Consolidate compiler generated dependencies of target ChemicalFeatures_static
Consolidate compiler generated dependencies of target testChemicalFeatures
[ 29%] Built target testChemicalFeatures
[ 29%] Built target ChemicalFeatures_static
[ 29%] Building CXX object Code/GraphMol/CMakeFiles/GraphMol.dir/AdjustQuery.cpp.o
[ 29%] Building CXX object Code/GraphMol/CMakeFiles/GraphMol_static.dir/AdjustQuery.cpp.o
In file included from /usr/include/signal.h:328,
                 from /cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/External/catch/catch/single_include/catch.hpp:4716,
                 from /cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/Code/SimDivPickers/catch_tests.cpp:13:
/cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/External/catch/catch/single_include/catch.hpp:7320:45: error: size of array ‘altStackMem’ is not an integral constant-expression
 7320 |     char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
      |                                             ^~~~~~~~
In file included from /usr/include/signal.h:328,
                 from /cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/External/catch/catch/single_include/catch.hpp:4716,
                 from /cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/Code/Geometry/catch_tests.cpp:3:
/cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/External/catch/catch/single_include/catch.hpp:7320:45: error: size of array ‘altStackMem’ is not an integral constant-expression
 7320 |     char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
      |                                             ^~~~~~~~
In file included from /usr/include/signal.h:328,
                 from /cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/External/catch/catch/single_include/catch.hpp:4716,
                 from /cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/Code/Numerics/testConrec.cpp:12:
/cache/bundle/ruby/2.6.0/bundler/gems/rdkit_chem-f96b802a7f22/rdkit/External/catch/catch/single_include/catch.hpp:7320:45: error: size of array ‘altStackMem’ is not an integral constant-expression
 7320 |     char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
      |                                             ^~~~~~~~
make[2]: *** [Code/SimDivPickers/CMakeFiles/pickersTestsCatch.dir/build.make:76: Code/SimDivPickers/CMakeFiles/pickersTestsCatch.dir/catch_tests.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:10860: Code/SimDivPickers/CMakeFiles/pickersTestsCatch.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [Code/Numerics/CMakeFiles/testConrec.dir/build.make:76: Code/Numerics/CMakeFiles/testConrec.dir/testConrec.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3386: Code/Numerics/CMakeFiles/testConrec.dir/all] Error 2
make[2]: *** [Code/Geometry/CMakeFiles/geometryTestsCatch.dir/build.make:76: Code/Geometry/CMakeFiles/geometryTestsCatch.dir/catch_tests.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:3330: Code/Geometry/CMakeFiles/geometryTestsCatch.dir/all] Error 2
[ 29%] Linking CXX shared library ../../lib/libRDKitcoordgen.so
[ 29%] Built target coordgen
[ 29%] Linking CXX static library libRDKitcoordgen_static.a
[ 29%] Built target coordgen_static
[ 29%] Linking CXX shared library ../../lib/libRDKitGraphMol.so
[ 29%] Linking CXX static library libRDKitGraphMol_static.a
[ 32%] Built target GraphMol_static
[ 35%] Built target GraphMol
make: *** [Makefile:166: all] Error 2
@ptrxyz
Copy link
Author

ptrxyz commented Aug 1, 2022

For reference, one thing I tried was to simply disable testing since it seems the problem is related to catch. No success though. :/

@ptrxyz
Copy link
Author

ptrxyz commented Dec 1, 2022

Still present as of today. Can we prioritize this as it's needed for the docker builds to work.

@ptrxyz
Copy link
Author

ptrxyz commented Mar 12, 2023

I'm bumping this up. Can you please take care of it? Would be a pity to fork this, just cause it's lingering around forever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant