-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance handling of axles/wheels #447
Comments
As for the proposal above, I'm not quite sure, if we should generalise more in the standard catalogue with regard to the instantiation. I guess there will be more things, which have to be adopted for a motor cycle. As we are now so close, I would rather see a specific layer file for motor cycles as an example or even as For the |
@danielwilms check if we get feedback how to create a "good" layer for motorbikes |
Handled by overlay concept, think we can close this one after the discussion |
The wheel-representation in VSS as of today (shown below) does not work that well for certain vehicles.
left
andright
wheel but just a single wheel on each axle.A possible change could be to address wheels similar to seats, i.e. instead of using left/right use positions:
But if we would do that we would open up for another question - and that is to review of what data we need for each wheel. If we look at https://github.com/COVESA/vehicle_signal_specification/blob/master/spec/Chassis/Wheel.vspec one can identify some areas where a change could be useful:
Brake.FluidLevel
is today given on wheel level, but how frequent is it that vehicle have separate brake fluid containers for individual wheels? Could likely be moved to "axle"-level, or a newBrakeSystem
branch that can have one or more instance, e.g. typically 1 instance for a passenger car and 2 systems for a motorbike.Brake.PadWear
- is today on wheel level, which will not work well if we start supporting twin wheels as they typically share the the same brake disc/drum/pads. I do not know how many vehicles that actually measure individual pad wear, or if they mostly just estimate padwear based on driving pattern. If they estimate padwear then the signal could likely be on axle-level. If measured, do we rather need a branchBrakeUnit
with row/pos instantiations, i.e an instantiation that does not necessarily needs to be the same as wheel instantiation? One brake unit could then server multiple wheels (typical truck use case), or multiple brake units could serve a single wheel (typical motorbike front wheel use case).Tire.Pressure
andTire.Temperature
are likely to be measured for each wheel individually.Thoughts?
The text was updated successfully, but these errors were encountered: