Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake tests ignore installed Catch2 #652

Closed
mpoquet opened this issue Oct 8, 2021 · 0 comments · Fixed by #653
Closed

CMake tests ignore installed Catch2 #652

mpoquet opened this issue Oct 8, 2021 · 0 comments · Fixed by #653

Comments

@mpoquet
Copy link

mpoquet commented Oct 8, 2021

As of latest commit 3ce61a1 or latest release v2.1.1, CMake tests always download Catch2 from a GitHub release instead of using an installed version if available.

This forces me to disable tests in the CLI11 Nix package in nixpkgs (I am updating it to CLI-v2.1.1) since Nix builds packages in a sandbox where they can only access their sources and not download external resources.

Can you update Catch2 CMake integration so that an installed Catch2 version is used if available? Installed Catch2 seems to be retrievable from CMake either via pkg-config (catch2.pc) or via CMake itself. This would change #include "catch.hpp" in tests to #include <catch2/catch.hpp>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant