-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calc_dragio functionality #463
Comments
Hi Elizabeth,
That's not correct. In the documentation (which I added in #366), we have (last paragraph of https://cice-consortium-icepack.readthedocs.io/en/main/science_guide/sg_boundary_forcing.html#ocean): Icepack/doc/source/science_guide/sg_boundary_forcing.rst Lines 305 to 320 in a80472b
and this is implemented in Icepack/columnphysics/icepack_parameters.F90 Lines 1648 to 1653 in a80472b
So under
No, it does not do nothing. It computes
I guess the same as a Canadian user :P That is, set I hope that's clear ? Let me know how you think the documentation could be improved. I guess the section I link to above would be clearer if the text also mentioned the corresponding code variables... |
I started #466, I'll update if we want more details. |
My question is a little different from the one you're answering -- sorry for not being clear. My assumption is that |
OK, yes I understand better now. It's true that it does not do much if they are constant. Currently both I went back to my PR (#366) and it turns out we quite a long discussion about it :) In fact, it seems you suggested the current approach (having the option to do the computation in Icepack itself). I'm not opposed to removing it and computing it outside Icepack (and CICE) if we feel it's more natural this way. One motivation for the current approach was that it added |
The option to calculate ice-ocean drag based on a (variable) under-ice ice roughness and the thickness of the ocean layer was added to icepack_parameters.F and the documentation, but apparently the actual calculation is done outside of icepack and the resulting value is sent in as the parameter
iceruf_ocn
. Is that correct? So settingcalc_dragio=.true.
in Icepack does nothing? Maybe we should write a warning in the Icepack driver to make that clear. Why isthickness_ocn_layer1
needed in Icepack? And a final question: what would a non-Canadian user need to do in CICE or somewhere else in their coupled model to make this work? A little more documentation on that point would be helpful, e.g. a sentence in layman's language that outlines the calculation. If someone is looking at Icepack without CICE, then it needs to be clear that this capability must be implemented outside of Icepack, that Icepack only ingests the results. I've been exploring it for E3SM, and it appears to be a bit of a science project. Thanks!The text was updated successfully, but these errors were encountered: