Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melts diagnostic bug #484

Closed
dabail10 opened this issue Jul 9, 2020 · 4 comments
Closed

melts diagnostic bug #484

dabail10 opened this issue Jul 9, 2020 · 4 comments
Assignees
@dabail10
Labels
Icepack Priority: High Type: Bug

Comments

@dabail10
Copy link
Contributor

dabail10 commented Jul 9, 2020

In the last part of the thickness_changes, when the sea ice completely melts away, the snow melt here is not added to melts. This is mostly diagnostic and likely will not change answers as the ice is going away for these points. It will change the history output and budgets that rely on melts.
@apcraig
Copy link
Contributor

apcraig commented Jul 22, 2020

Is this CICE-Consortium/Icepack#328?

@dabail10
Copy link
Contributor Author

Yes it is. I put the issue in the CICE Issues. Should it be in Icepack issues? I am currently working on running the QC tests with this fix.

@apcraig
Copy link
Contributor

apcraig commented Jul 22, 2020

It could be in Icepack, but also fine here. Glad to hear testing is proceeding, update the PR when you have some more results. Thanks!

@apcraig
Copy link
Contributor

apcraig commented Jul 29, 2020

This was fixed in Icepack but has not yet been merged into CICE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dabail10 dabail10

Labels
Icepack Priority: High Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eclare108213 @apcraig @dabail10