Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A metadata approach to fitting directories? #156

Open
SamuelBrand1 opened this issue Nov 21, 2024 · 3 comments
Open

A metadata approach to fitting directories? #156

SamuelBrand1 opened this issue Nov 21, 2024 · 3 comments

Comments

@SamuelBrand1
Copy link
Collaborator

At the moment we are gathering important information about inference/score runs based on specific locations in a directory structure, and parsing the dir name,

e.g.

parse_model_run_dir_path <- function(model_run_dir_path) {
batch_dir <- model_run_dir_path |>
fs::path_dir() |>
fs::path_dir() |>
fs::path_file()
location <- fs::path_file(model_run_dir_path)
return(c(
location = location,
parse_model_batch_dir_path(batch_dir)
))
}

This will work well for us at the moment, but I think its inflexible in the medium term because it hard encodes the expected directory structure.

I'm personally against encoding information in dirnames, I'd prefer an autogenerated set of metadata for runs either as a .toml file that gets generated as the inference is done or handled by a work scheduling tool e.g. something like mlflow. I might well be missing something though.

@damonbayer
Copy link
Collaborator

This could help with some of the naming collisions I mentioned in #126

@damonbayer
Copy link
Collaborator

Related to #62

@dylanhmorris
Copy link
Contributor

I agree and favor a .toml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants