Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make path handling more robust in fit_model and build_model_from_dir #142

Open
dylanhmorris opened this issue Nov 19, 2024 · 0 comments
Open

Make path handling more robust in fit_model and build_model_from_dir #142

dylanhmorris opened this issue Nov 19, 2024 · 0 comments
Labels
cleanup

Comments

@dylanhmorris
Copy link
Contributor

dylanhmorris commented Nov 19, 2024 •
edited
Loading

The below solution works for now, but we should investigate whether there are string startswith() calls that should really be path manipulation.

The positional form for fit_model script was causing an error in its call down to build_model_from_dir because runpy.run_path(prior_path) was failing

AttributeError: 'PosixPath' object has no attribute 'startswith'

An easy fix committed here was to convert to string at this point.

Originally posted by @SamuelBrand1 in #138 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanhmorris @damonbayer