Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse-proxy-guard authenticates request without valid headers configuration #84

Closed
Bubka opened this issue May 18, 2022 · 0 comments
Closed

Reverse-proxy-guard authenticates request without valid headers configuration #84

Bubka opened this issue May 18, 2022 · 0 comments
Labels
bug Something isn't working fixed The issue is fixed (in a coming release)

Comments

@Bubka
Copy link
Owner

Bubka commented May 18, 2022

Describe the bug
Reverse-proxy-guard authenticates request without valid headers configuration.

To Reproduce
Steps to reproduce the behavior:

  1. Set AUTHENTICATION_GUARD=reverse-proxy-guard and a proxy in front of 2FAuth
  2. Set AUTH_PROXY_HEADER_FOR_USER=null or AUTH_PROXY_HEADER_FOR_USER=
  3. Open /settings/account

Expected behavior
The request should be rejected as unauthenticated
@Bubka Bubka added bug Something isn't working fixed The issue is fixed (in a coming release) labels May 18, 2022
@Bubka Bubka moved this to Todo in 2FAuth backlog May 18, 2022
@Bubka Bubka moved this from Todo to In Progress in 2FAuth backlog May 18, 2022
@Bubka Bubka closed this as completed in 0199ad3 May 23, 2022
Repository owner moved this from In Progress to Done in 2FAuth backlog May 23, 2022
@Bubka Bubka removed this from 2FAuth backlog Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed The issue is fixed (in a coming release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bubka