Skip to content

Commit 6203435

Browse files
authored
chore: remove legacy C plugin integration (lancedb#3243)
The plugin hasn't built in over a year and the fact that we have git submodules can cause expensive build times for downstream projects like lancedb when they need to declare a git dependency on lance. If we need it back later we can always revert the change.
1 parent c310aee commit 6203435

31 files changed

+0
-1989
lines changed

.github/workflows/duckdb.yml

-64
This file was deleted.

.gitignore

-5
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,6 @@ docs/api/python
6767
**/.ipynb_checkpoints/
6868
docs/notebooks
6969

70-
71-
integration/duckdb/*-build
72-
integration/duckdb/lance.duckdb_extension.*.zip
73-
74-
notebooks/lance.duckdb_extension
7570
notebooks/sift
7671
notebooks/image_data/data
7772
benchmarks/sift/sift

.gitmodules

-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +0,0 @@
1-
[submodule "integration/duckdb_lance/duckdb"]
2-
path = integration/duckdb_lance/duckdb
3-
url = https://github.com/duckdb/duckdb.git
4-
[submodule "integration/duckdb_lance/duckdb-ext/duckdb"]
5-
path = integration/duckdb_lance/duckdb-ext/duckdb
6-
url = https://github.com/duckdb/duckdb.git

docs/contributing.rst

-7
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,6 @@ Example Notebooks
127127

128128
Example notebooks are under `examples`. These are standalone notebooks you should be able to download and run.
129129

130-
DuckDB Extension
131-
~~~~~~~~~~~~~~~~
132-
133-
In python, Lance integrates with DuckDB via Apache Arrow. Outside of python, the highly experimental duckdb extension for Lance
134-
lives under `integration/duckdb_lance`. This uses the DuckDB `Rust extension framework <https://github.com/Mause/duckdb-extension-framework>`_.
135-
The main code lives under `integration/duckdb_lance/src`. Follow the integration README for more details.
136-
137130
Benchmarks
138131
~~~~~~~~~~
139132

integration/duckdb_lance/CMakeLists.txt

-72
This file was deleted.

integration/duckdb_lance/Cargo.toml

-21
This file was deleted.

integration/duckdb_lance/Makefile

-21
This file was deleted.

integration/duckdb_lance/README.md

-10
This file was deleted.

integration/duckdb_lance/duckdb

-1
This file was deleted.

integration/duckdb_lance/duckdb-ext/Cargo.toml

-11
This file was deleted.

integration/duckdb_lance/duckdb-ext/README.md

-6
This file was deleted.

integration/duckdb_lance/duckdb-ext/build.rs

-40
This file was deleted.
This file was deleted.

integration/duckdb_lance/duckdb-ext/src/connection.rs

-41
This file was deleted.

0 commit comments

Comments
 (0)