From d18acb6f2d6126b1c670392fc7ab5af3dbb61197 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Wed, 6 Mar 2024 08:23:33 -0800 Subject: [PATCH] Implement appearance:bikeshed for StylableSelect This patch gates all the new rendering and interaction behavior for StylableSelect behind a new "bikeshed" value for the appearance property. No name has been decided for this property yet, hence the "bikeshed" name. The UA stylesheet will still only look at whether there is a slotted button or datalist present rather than the appearance property because looking at the appearance property to determine whether to apply UA style rules or not would cause circular style and would at least require two style updates in order to work, which is not acceptable. Bug: 1511354 Change-Id: I5f476f9a912aee7391dc4409473676de48c4028c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5315083 Reviewed-by: Mason Freed Commit-Queue: Joey Arhar Cr-Commit-Position: refs/heads/main@{#1269013} --- ...n-and-datalist-invalidation.tentative.html | 23 +++++++++++++++++++ ...t-child-button-and-datalist.tentative.html | 2 +- 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 html/semantics/forms/the-select-element/select-child-button-and-datalist-invalidation.tentative.html diff --git a/html/semantics/forms/the-select-element/select-child-button-and-datalist-invalidation.tentative.html b/html/semantics/forms/the-select-element/select-child-button-and-datalist-invalidation.tentative.html new file mode 100644 index 000000000000000..f71c1e52fc612ba --- /dev/null +++ b/html/semantics/forms/the-select-element/select-child-button-and-datalist-invalidation.tentative.html @@ -0,0 +1,23 @@ + + + + + + + + + + + diff --git a/html/semantics/forms/the-select-element/select-child-button-and-datalist.tentative.html b/html/semantics/forms/the-select-element/select-child-button-and-datalist.tentative.html index b74957feed89b7c..54785ace95150ef 100644 --- a/html/semantics/forms/the-select-element/select-child-button-and-datalist.tentative.html +++ b/html/semantics/forms/the-select-element/select-child-button-and-datalist.tentative.html @@ -5,7 +5,7 @@ -