Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character replacement, possibly an encoding issue #701

Closed
colinrotherham opened this issue Jun 30, 2015 · 3 comments · May be fixed by shakyShane/resp-modifier#15
Closed

Character replacement, possibly an encoding issue #701

colinrotherham opened this issue Jun 30, 2015 · 3 comments · May be fixed by shakyShane/resp-modifier#15

Comments

@colinrotherham
Copy link

Hi,

I've noticed the following HTML markup is being replaced from this:
<p class="scroller__description">Video’s your choice, available when your visitors and agents want.</p>

To this (over the Browsersync proxy):
<p class="scroller__description">Video���s your choice, available when your visitors and agents want.</p>

i.e. A curly single quote is becoming ���

Other single quotes, double quotes or other unicode characters are displaying correctly—perhaps this is a string replacement or regex issue? Changing the class attribute fixes the issue.

Could possibly be related to issue #661

Thanks

@shakyShane
Copy link
Contributor

@colinrotherham Can you provide an example repo showing this bug? I'm unable to reproduce it.

@colinrotherham
Copy link
Author

Sorry, I can no longer reproduce it on the latest version. Feel free to close this one.

Changing scroller__description to scroller__text avoided the issue at the time. I did wonder if it was matching script within the class attribute and doing something it shouldn't have been.

Thanks

@MrVoltz
Copy link

MrVoltz commented Oct 4, 2023

I have the same issue and my suspicion is that Browsersync decodes the incoming stream in chunks and sometimes the chunk boundary lies in the middle of an UTF-8 character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants