Image Gallery support for local image

[noklam]

Current behavior

Currently the image gallery only support images with https URL, however the native URL for Boostnote (:storage/xxx/xxx) does not work.

The only way to get it works for now is to use absolute path like file explorer

Related Issue: #2465

Expected behavior

The expected behavior should be :storage style relative path should be work for Image Gallery

Steps to reproduce

Environment

• Version :
• OS Version and name :
  Window 10
  Boostnote 0.11.15

---

IssueHunt Summary

daiyam has been rewarded.

Backers (Total: $30.00)

• boostio ($30.00)

Submitted pull Requests

• #3027 fix gallery on windows

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[noklam]

@daiyam Thanks for building this image gallery function, this is awesome. It would be great if it works for normal boostnote style URL. Otherwise the image URL could be easily broken when photos are moving around.

[daiyam]

@noklam the issue seems to be with windows style URL :storage\xxx\xxx instead of :storage/xxx/xxx.

[noklam]

@daiyam You are correct. the back slash "" works fine though if it is a classic image

[ZeroX-DG]

Same problem as #2834

[noklam]

@ZeroX-DG I am not sure if they are the same problem. As noted I am using Boostnote 0.11.15 which include the bug fix from your reference issue already.

#2834 shows local images issue with "/" and "". As shown in my previous comment, "/" and "" works perfectly fine with local image, it only fails for Gallery. They are probably a related issue, but Gallery is quite a new feature so maybe the last fix #2834 did not take care of Gallery?
If possible please re-open this issue.

[noklam]

@ZeroX-DG Also please notice the 2nd image of the issue, even with "" the image render correctly if I use full path instead of :storage, I am using 0.11.15 already so this is a bug that have not been fixed.

[daiyam]

@noklam I will try to make a fix this week-end

[noklam]

@daiyam Great, thank you! I just start to learn electron today, looking forward to seeing your fix. 😀

[IssueHuntBot]

@BoostIO has funded $30.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[daiyam]

Sorry about the delay, I've forgotten to do the fix...

[noklam]

@daiyam looks like there is a fix implemented? Will this fix be merged soon?

[daiyam]

@noklam sorry, I have no idea...

[Flexo013]

I have contacted Rokt33r about the PR containing the fix. With this I expect the fix to merged in the next few days. That also means that it will be part of the next release, which should be within a week.

[daiyam]

@Flexo013 great! thx

[Flexo013]

This is fixed in the 0.12.0 release that you can download now! Thanks to #3027.

[issuehunt-oss]

@Rokt33r has rewarded $27.00 to @daiyam. See it on IssueHunt

• 💰 Total deposit: $30.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $3.00