From ab296fddf380faa5a7a175b7d3226fec3f9a02ba Mon Sep 17 00:00:00 2001 From: Alex Oleshkevich Date: Mon, 17 Apr 2023 12:52:15 +0200 Subject: [PATCH] Fix types in lifespan examples (#2123) --- docs/lifespan.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/lifespan.md b/docs/lifespan.md index 7dceacc7b..88c49c064 100644 --- a/docs/lifespan.md +++ b/docs/lifespan.md @@ -43,6 +43,7 @@ from typing import TypedDict import httpx from starlette.applications import Starlette +from starlette.requests import Request from starlette.responses import PlainTextResponse from starlette.routing import Route @@ -52,12 +53,12 @@ class State(TypedDict): @contextlib.asynccontextmanager -async def lifespan(app: Starlette) -> State: +async def lifespan(app: Starlette) -> typing.AsyncIterator[State]: async with httpx.AsyncClient() as client: yield {"http_client": client} -async def homepage(request): +async def homepage(request: Request) -> PlainTextResponse: client = request.state.http_client response = await client.get("https://www.example.com") return PlainTextResponse(response.text)