Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is address_to_bytes used for? #53

Open
akx opened this issue Jul 29, 2024 · 2 comments
Open

What is address_to_bytes used for? #53

akx opened this issue Jul 29, 2024 · 2 comments

Comments

@akx
Copy link
Contributor

akx commented Jul 29, 2024

The test for address_to_bytes looks pretty suspect:

assert address_to_bytes("00:00:00:00:00:00") == b"\x00\x00\x00\x00"

– why would bytes-ifying a 6-octet string result in 4 binary bytes?

That said, it doesn't look like anything within the library uses the (possibly broken?) function. Should it be removed?

@bdraco
Copy link
Member

bdraco commented Jul 29, 2024

I think one of the ble libs uses it but I can remember which one for the life of me

@bdraco
Copy link
Member

bdraco commented Feb 2, 2025

I can't seem to find any usage of it. I think we can drop it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants