Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Settings component on Login view #17

Open
iamkevinlowe opened this issue Apr 3, 2016 · 1 comment
Open

Remove Settings component on Login view #17

iamkevinlowe opened this issue Apr 3, 2016 · 1 comment

Comments

@iamkevinlowe
Copy link
Contributor

Settings button, leading to LOG OUT is shown on Login view.

screen shot 2016-04-03 at 10 52 31 am

@dpaola2
Copy link
Contributor

dpaola2 commented Apr 15, 2016

I investigated this a bit, posting here for posterity.

The reason this occurs is because the index.ios.js component includes the Settings component from within its rendered NavigatorIOS component (as a property).

One solution is to extract a separate NavigatorIOS component for the logged-out view vs. the logged-in view. That seems like overkill to me.

Another solution would be to simply include the Settings component and render different contents depending on whether or not the user is logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants