Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard/controller input breaks down with FSR-filters #689

Closed
Doze-D opened this issue Jul 26, 2023 · 3 comments · Fixed by #643
Closed

Keyboard/controller input breaks down with FSR-filters #689

Doze-D opened this issue Jul 26, 2023 · 3 comments · Fixed by #643
Labels
bug Something isn't working

Comments

@Doze-D
Copy link

Doze-D commented Jul 26, 2023

Magpie version 程序版本

0.10.3

Windows version 系统版本

Win10, 22H2

Related screenshot (optional) 相关截图(可选)

No response

Reproduction steps 复现步骤

Tested out scaling methods to get one game into fullscreen from 1280x960 window, all of them worked just fine, but for some reason, when I picked up FSR_EASU, keyboard and controller couldn't input anything to the game apart from F-keys. Keyboard and controller worked fine on other games thou after this. And input didn't work on this particular game using this app until I rebooted the whole computer. Never seen this happen before. Looks like either this program or FSR-plugin(s) hook to Dinput-system and mess it up somehow, but only with the program that you just used the scaler with.

Log files 日志文件

magpie.log

@Doze-D Doze-D added the bug Something isn't working label Jul 26, 2023
@Blinue
Copy link
Owner

Blinue commented Jul 27, 2023

There is indeed a keyboard hook that may cause compatibility issues. I’m working on this.

@Doze-D
Copy link
Author

Doze-D commented Jul 27, 2023

There is indeed a keyboard hook that may cause compatibility issues. I’m working on this.

Allright, good. Also, it seems that when going between different capture methods, it unlocks the framerate and shoots it up to 2000-3000fps in some cases. You could add some kind of cap for that or option to cap it. Graphics Capture-option uses the same what the game uses, but the other options freely jump up to maximum unless you use VSync.

@Blinue
Copy link
Owner

Blinue commented Jul 28, 2023

I suggest always enabling VSync to prevent Magpie from consuming excessive resources. I'm currently rewriting the rendering process to completely address this issue.

@Blinue Blinue linked a pull request Jul 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants