From 396ce1c34eed1dbedcf1c41ce8a54ccd8aafe30a Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 18:17:28 -0800 Subject: [PATCH 01/19] Added GitHub actions script to build Tableau and Power BI connector. The PBI connector is being built twice with different names accroding to the Amazon's request. Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 41 +++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/bi-connectors.yml diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml new file mode 100644 index 0000000000..598ad9617b --- /dev/null +++ b/.github/workflows/bi-connectors.yml @@ -0,0 +1,41 @@ +name: Build connectors for BI tools + +on: + push: + paths: + - 'bi-connectors/PowerBIConnector/**' + - 'bi-connectors/TableauConnector/**' + +jobs: + build: + runs-on: ubuntu-latest +# defaults: +# run: +# working-directory: sql-odbc + steps: + - uses: actions/checkout@v1 + - name: Pack Tableau JDBC connector + run: | + zip -r opensearch_sql_jdbc.taco bi-connectors/TableauConnector/opensearch_sql_jdbc -x *.taco + - name: Pack Power BI ODBC connector + run: | + zip OpenSearch-project.mez bi-connectors/PowerBIConnector + - name: Prepare the second Power BI ODBC connector + run: | + sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' bi-connectors/PowerBIConnector/resources.resx + sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq + - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' + run: | + zip Amazon-OpenSearch-Service.mez bi-connectors/PowerBIConnector + - name: Upload Tableau JDBC connector + if: success() + uses: actions/upload-artifact@v2 + with: + name: TableauConnector + path: opensearch_sql_jdbc.taco + - name: Upload Power BI ODBC connectors + if: success() + uses: actions/upload-artifact@v2 + with: + name: PBIConnectors + path: *.mez From 1d3cceb2623041fc2e778b208dcfbc002c0fa286 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 18:28:06 -0800 Subject: [PATCH 02/19] A typo fix in yml Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 598ad9617b..4eb7ffee7b 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -38,4 +38,4 @@ jobs: uses: actions/upload-artifact@v2 with: name: PBIConnectors - path: *.mez + path: '*.mez' From c277fe2c9aa5b43b2e223534bcb343e510196641 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 18:33:16 -0800 Subject: [PATCH 03/19] A dummy commit to make GitHub Actions start the desired workflow Signed-off-by: Yury Fridlyand --- bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq b/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq index 0a4bbf09eb..79dce23391 100644 --- a/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq +++ b/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq @@ -229,7 +229,7 @@ Extension.LoadFunction = (name as text) => in Expression.Evaluate(asText, #shared); -// Diagnostics module contains multiple functions. . +// Diagnostics module contains multiple functions. Diagnostics = Extension.LoadFunction("Diagnostics.pqm"); Diagnostics.LogValue = if (EnableTraceOutput) then Diagnostics[LogValue] else (prefix, value) => value; From 2be30f33058e5c9b9927918289aa407f52a5c36e Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 18:46:13 -0800 Subject: [PATCH 04/19] Workflow fix - pack Tableau ODBC connector instead of JDBC one Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 4eb7ffee7b..01d73a1c4a 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -14,9 +14,9 @@ jobs: # working-directory: sql-odbc steps: - uses: actions/checkout@v1 - - name: Pack Tableau JDBC connector + - name: Pack Tableau ODBC connector run: | - zip -r opensearch_sql_jdbc.taco bi-connectors/TableauConnector/opensearch_sql_jdbc -x *.taco + zip -r opensearch_sql_odbc.taco bi-connectors/TableauConnector/opensearch_sql_odbc -x *.taco - name: Pack Power BI ODBC connector run: | zip OpenSearch-project.mez bi-connectors/PowerBIConnector @@ -27,12 +27,12 @@ jobs: - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' run: | zip Amazon-OpenSearch-Service.mez bi-connectors/PowerBIConnector - - name: Upload Tableau JDBC connector + - name: Upload Tableau ODBC connector if: success() uses: actions/upload-artifact@v2 with: name: TableauConnector - path: opensearch_sql_jdbc.taco + path: opensearch_sql_odbc.taco - name: Upload Power BI ODBC connectors if: success() uses: actions/upload-artifact@v2 From 604adbf2e5b0b56e83a3eb100e851ff20e3b2805 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 18:46:47 -0800 Subject: [PATCH 05/19] Fix line endings in the workflow file Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 82 ++++++++++++++--------------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 01d73a1c4a..7d38ea76eb 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -1,41 +1,41 @@ -name: Build connectors for BI tools - -on: - push: - paths: - - 'bi-connectors/PowerBIConnector/**' - - 'bi-connectors/TableauConnector/**' - -jobs: - build: - runs-on: ubuntu-latest -# defaults: -# run: -# working-directory: sql-odbc - steps: - - uses: actions/checkout@v1 - - name: Pack Tableau ODBC connector - run: | - zip -r opensearch_sql_odbc.taco bi-connectors/TableauConnector/opensearch_sql_odbc -x *.taco - - name: Pack Power BI ODBC connector - run: | - zip OpenSearch-project.mez bi-connectors/PowerBIConnector - - name: Prepare the second Power BI ODBC connector - run: | - sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' bi-connectors/PowerBIConnector/resources.resx - sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq - - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' - run: | - zip Amazon-OpenSearch-Service.mez bi-connectors/PowerBIConnector - - name: Upload Tableau ODBC connector - if: success() - uses: actions/upload-artifact@v2 - with: - name: TableauConnector - path: opensearch_sql_odbc.taco - - name: Upload Power BI ODBC connectors - if: success() - uses: actions/upload-artifact@v2 - with: - name: PBIConnectors - path: '*.mez' +name: Build connectors for BI tools + +on: + push: + paths: + - 'bi-connectors/PowerBIConnector/**' + - 'bi-connectors/TableauConnector/**' + +jobs: + build: + runs-on: ubuntu-latest +# defaults: +# run: +# working-directory: sql-odbc + steps: + - uses: actions/checkout@v1 + - name: Pack Tableau ODBC connector + run: | + zip -r opensearch_sql_odbc.taco bi-connectors/TableauConnector/opensearch_sql_odbc -x *.taco + - name: Pack Power BI ODBC connector + run: | + zip OpenSearch-project.mez bi-connectors/PowerBIConnector + - name: Prepare the second Power BI ODBC connector + run: | + sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' bi-connectors/PowerBIConnector/resources.resx + sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq + - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' + run: | + zip Amazon-OpenSearch-Service.mez bi-connectors/PowerBIConnector + - name: Upload Tableau ODBC connector + if: success() + uses: actions/upload-artifact@v2 + with: + name: TableauConnector + path: opensearch_sql_odbc.taco + - name: Upload Power BI ODBC connectors + if: success() + uses: actions/upload-artifact@v2 + with: + name: PBIConnectors + path: '*.mez' From 91dd569f057daeb96b41eaaa717e599a696bebc1 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 18:49:17 -0800 Subject: [PATCH 06/19] Another dummy commit to start the desired workflow Signed-off-by: Yury Fridlyand --- .../PowerBIConnector/SqlOdbcPBIConnector.pq | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq b/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq index 79dce23391..41c5d6845a 100644 --- a/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq +++ b/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq @@ -159,7 +159,7 @@ OnOdbcError = (errorRecord as record) => else error errorRecord; -// Data Source Kind description +// Data Source Kind description. SqlOdbcPBIConnector = [ // Required for use with Power BI Service. TestConnection = (dataSourcePath) => @@ -169,7 +169,7 @@ SqlOdbcPBIConnector = [ in { "SqlOdbcPBIConnector.Contents", Server }, - // Authentication modes + // Authentication modes. Authentication = [ Implicit = [ Label = "NONE" @@ -183,7 +183,7 @@ SqlOdbcPBIConnector = [ ] ], - // PBIDS Handler + // PBIDS Handler. DSRHandlers = [ #"sqlodbc" = [ GetDSR = (server, schema, object, optional options) => [ protocol = "sqlodbc", address = [ server = server ] ], @@ -196,13 +196,13 @@ SqlOdbcPBIConnector = [ ] ], - // Enable Encryption + // Enable Encryption. SupportsEncryption = true, Label = Extension.LoadString("DataSourceLabel") ]; -// Data Source UI publishing description +// Data Source UI publishing description. SqlOdbcPBIConnector.Publish = [ Beta = true, Category = "Other", @@ -221,7 +221,7 @@ SqlOdbcPBIConnector.Icons = [ Icon32 = { Extension.Contents("SqlOdbcPBIConnector32.png"), Extension.Contents("SqlOdbcPBIConnector40.png"), Extension.Contents("SqlOdbcPBIConnector48.png"), Extension.Contents("SqlOdbcPBIConnector64.png") } ]; -// Load common library functions +// Load common library functions. Extension.LoadFunction = (name as text) => let binary = Extension.Contents(name), From 6b89593b91972278bcaed7e4c7cbb551f89b1f1a Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 19:59:19 -0800 Subject: [PATCH 07/19] Fix paths in the GitHub workflow Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 7d38ea76eb..aab94b1581 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -16,26 +16,33 @@ jobs: - uses: actions/checkout@v1 - name: Pack Tableau ODBC connector run: | - zip -r opensearch_sql_odbc.taco bi-connectors/TableauConnector/opensearch_sql_odbc -x *.taco + zip -r opensearch_sql_odbc.taco . -x *.taco + working-directory: bi-connectors/TableauConnector/opensearch_sql_odbc + - name: Prepare Power BI ODBC connector + run: | + cp SqlOdbcPBIConnector.pq SqlOdbcPBIConnector.m - name: Pack Power BI ODBC connector run: | - zip OpenSearch-project.mez bi-connectors/PowerBIConnector + zip OpenSearch-project.mez *.png *.m *.resx *.pqm + working-directory: bi-connectors/PowerBIConnector - name: Prepare the second Power BI ODBC connector run: | - sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' bi-connectors/PowerBIConnector/resources.resx - sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq + sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' resources.resx + sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' SqlOdbcPBIConnector.m + working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' run: | - zip Amazon-OpenSearch-Service.mez bi-connectors/PowerBIConnector + zip Amazon-OpenSearch-Service.mez *.png *.m *.resx *.pqm + working-directory: bi-connectors/PowerBIConnector - name: Upload Tableau ODBC connector if: success() uses: actions/upload-artifact@v2 with: name: TableauConnector - path: opensearch_sql_odbc.taco + path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco - name: Upload Power BI ODBC connectors if: success() uses: actions/upload-artifact@v2 with: name: PBIConnectors - path: '*.mez' + path: 'bi-connectors/PowerBIConnector/*.mez' From 015fa7b870e58de25b2ebea90f82f438ad71c980 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 20:07:44 -0800 Subject: [PATCH 08/19] Modified workflow to trigger on changes of itself Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index aab94b1581..f3b9bf0d44 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -5,6 +5,7 @@ on: paths: - 'bi-connectors/PowerBIConnector/**' - 'bi-connectors/TableauConnector/**' + - '.github/workflows/bi-connectors.yml' jobs: build: From 081392ede7476e9e8218adf34598d5a4c6651401 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Thu, 16 Dec 2021 20:11:15 -0800 Subject: [PATCH 09/19] Path fix for preparation step Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index f3b9bf0d44..099f05bc27 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -22,6 +22,7 @@ jobs: - name: Prepare Power BI ODBC connector run: | cp SqlOdbcPBIConnector.pq SqlOdbcPBIConnector.m + working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector run: | zip OpenSearch-project.mez *.png *.m *.resx *.pqm From 450d4839f598baedab6e337323da6a165ac1c9d5 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Fri, 17 Dec 2021 10:09:05 -0800 Subject: [PATCH 10/19] Added some changes to the second PBI connector - they should differ more than in filename to make PBI distuingish them Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 099f05bc27..52af2eaec4 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -10,9 +10,6 @@ on: jobs: build: runs-on: ubuntu-latest -# defaults: -# run: -# working-directory: sql-odbc steps: - uses: actions/checkout@v1 - name: Pack Tableau ODBC connector @@ -31,6 +28,7 @@ jobs: run: | sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' resources.resx sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' SqlOdbcPBIConnector.m + sed -i 's/SqlOdbcPBIConnector\([^1-9]\)/AmazonOpenSearchConnector\1/g' SqlOdbcPBIConnector.m working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' run: | From a62bdd17977ad6d510ce077a4f2d439e45a80644 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Fri, 17 Dec 2021 10:44:51 -0800 Subject: [PATCH 11/19] Renamed PBI connector files Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 52af2eaec4..a36450103f 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -22,7 +22,7 @@ jobs: working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector run: | - zip OpenSearch-project.mez *.png *.m *.resx *.pqm + zip OpenSearchProject.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector - name: Prepare the second Power BI ODBC connector run: | @@ -32,7 +32,7 @@ jobs: working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' run: | - zip Amazon-OpenSearch-Service.mez *.png *.m *.resx *.pqm + zip AmazonOpenSearchService.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector - name: Upload Tableau ODBC connector if: success() From 47530d0d1acd0d6fc8cc59c1fca2e00149e1d31e Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Fri, 17 Dec 2021 10:57:15 -0800 Subject: [PATCH 12/19] Moved Tableau JDBC connector to bi-connectors Signed-off-by: Yury Fridlyand --- .../opensearch_sql_jdbc/META-INF/MANIFEST.MF | 0 .../opensearch_sql_jdbc/connection-fields.xml | 0 .../opensearch_sql_jdbc/connection-metadata.xml | 0 .../opensearch_sql_jdbc/connectionBuilder.js | 0 .../opensearch_sql_jdbc/connectionResolver.tdr | 0 .../opensearch_sql_jdbc/dialect.tdd | 0 .../opensearch_sql_jdbc/manifest.xml | 0 .../opensearch_sql_jdbc_dev.taco | Bin 8 files changed, 0 insertions(+), 0 deletions(-) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/META-INF/MANIFEST.MF (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/connection-fields.xml (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/connection-metadata.xml (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/connectionBuilder.js (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/connectionResolver.tdr (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/dialect.tdd (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/manifest.xml (100%) rename {sql-jdbc/src => bi-connectors}/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc_dev.taco (100%) diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/META-INF/MANIFEST.MF b/bi-connectors/TableauConnector/opensearch_sql_jdbc/META-INF/MANIFEST.MF similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/META-INF/MANIFEST.MF rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/META-INF/MANIFEST.MF diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connection-fields.xml b/bi-connectors/TableauConnector/opensearch_sql_jdbc/connection-fields.xml similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connection-fields.xml rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/connection-fields.xml diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connection-metadata.xml b/bi-connectors/TableauConnector/opensearch_sql_jdbc/connection-metadata.xml similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connection-metadata.xml rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/connection-metadata.xml diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connectionBuilder.js b/bi-connectors/TableauConnector/opensearch_sql_jdbc/connectionBuilder.js similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connectionBuilder.js rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/connectionBuilder.js diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connectionResolver.tdr b/bi-connectors/TableauConnector/opensearch_sql_jdbc/connectionResolver.tdr similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/connectionResolver.tdr rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/connectionResolver.tdr diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/dialect.tdd b/bi-connectors/TableauConnector/opensearch_sql_jdbc/dialect.tdd similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/dialect.tdd rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/dialect.tdd diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/manifest.xml b/bi-connectors/TableauConnector/opensearch_sql_jdbc/manifest.xml similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/manifest.xml rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/manifest.xml diff --git a/sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc_dev.taco b/bi-connectors/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc_dev.taco similarity index 100% rename from sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc_dev.taco rename to bi-connectors/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc_dev.taco From 21e0bdf3a3c14506bc54870b900d545dd21060ab Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Fri, 17 Dec 2021 11:09:46 -0800 Subject: [PATCH 13/19] Added packing Tableau JDBC connector For all connectors added check for successful packing before publishing Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index a36450103f..291fa000d7 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -13,35 +13,50 @@ jobs: steps: - uses: actions/checkout@v1 - name: Pack Tableau ODBC connector + id: pack-tableau-odbc run: | zip -r opensearch_sql_odbc.taco . -x *.taco working-directory: bi-connectors/TableauConnector/opensearch_sql_odbc + - name: Pack Tableau JDBC connector + id: pack-tableau-jdbc + run: | + zip -r opensearch_sql_jdbc.taco . -x *.taco + working-directory: bi-connectors/TableauConnector/opensearch_sql_jdbc - name: Prepare Power BI ODBC connector run: | cp SqlOdbcPBIConnector.pq SqlOdbcPBIConnector.m working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector + id: pack-powerbi-odbc-os-proj run: | zip OpenSearchProject.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector - name: Prepare the second Power BI ODBC connector + id: prep-powerbi-odbc-amz-os-svc run: | sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' resources.resx sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' SqlOdbcPBIConnector.m sed -i 's/SqlOdbcPBIConnector\([^1-9]\)/AmazonOpenSearchConnector\1/g' SqlOdbcPBIConnector.m working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' + id: pack-powerbi-odbc-amz-os-svc run: | zip AmazonOpenSearchService.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector - name: Upload Tableau ODBC connector - if: success() + if: steps.pack-tableau-odbc.outcome == 'success' uses: actions/upload-artifact@v2 with: name: TableauConnector path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco + - name: Upload Tableau JDBC connector + if: steps.pack-tableau-jdbc.outcome == 'success' + uses: actions/upload-artifact@v2 + with: + name: TableauConnector + path: bi-connectors/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc.taco - name: Upload Power BI ODBC connectors - if: success() + if: steps.pack-powerbi-odbc-os-proj.outcome == 'success' || (steps.prep-powerbi-odbc-amz-os-svc.outcome == 'success' && steps.pack-powerbi-odbc-amz-os-svc.outcome == 'success') uses: actions/upload-artifact@v2 with: name: PBIConnectors From f5692ccdce2c3669c6f2098ef3643bc6602d2404 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Fri, 17 Dec 2021 12:19:27 -0800 Subject: [PATCH 14/19] Renamed Power BI connector as "OpenSearch Project" Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 4 ++-- bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq | 2 +- bi-connectors/PowerBIConnector/resources.resx | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 291fa000d7..84bf0aaf20 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -34,8 +34,8 @@ jobs: - name: Prepare the second Power BI ODBC connector id: prep-powerbi-odbc-amz-os-svc run: | - sed -i 's/OpenSearch<\/value>/Amazon OpenSearch Service<\/value>/g' resources.resx - sed -i 's/Documentation.Name = "OpenSearch"/Documentation.Name = "Amazon OpenSearch Service"/g' SqlOdbcPBIConnector.m + sed -i 's/OpenSearch Project<\/value>/Amazon OpenSearch Service<\/value>/g' resources.resx + sed -i 's/Documentation.Name = "OpenSearch Project"/Documentation.Name = "Amazon OpenSearch Service"/g' SqlOdbcPBIConnector.m sed -i 's/SqlOdbcPBIConnector\([^1-9]\)/AmazonOpenSearchConnector\1/g' SqlOdbcPBIConnector.m working-directory: bi-connectors/PowerBIConnector - name: Pack Power BI ODBC connector for 'Amazon OpenSearch Service' diff --git a/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq b/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq index 41c5d6845a..830343e6af 100644 --- a/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq +++ b/bi-connectors/PowerBIConnector/SqlOdbcPBIConnector.pq @@ -19,7 +19,7 @@ SqlOdbcPBIConnectorType = type function ( ]) ) as table meta [ - Documentation.Name = "OpenSearch" + Documentation.Name = "OpenSearch Project" ]; SqlOdbcPBIConnectorImpl = (Server as text) as table => diff --git a/bi-connectors/PowerBIConnector/resources.resx b/bi-connectors/PowerBIConnector/resources.resx index 3642a474fe..3db608e458 100644 --- a/bi-connectors/PowerBIConnector/resources.resx +++ b/bi-connectors/PowerBIConnector/resources.resx @@ -121,9 +121,9 @@ Connect to OpenSearch - OpenSearch + OpenSearch Project - OpenSearch + OpenSearch Project \ No newline at end of file From a432ac266688125dc149bc87c6d98a1bf4c246e7 Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Fri, 17 Dec 2021 12:28:46 -0800 Subject: [PATCH 15/19] Renamed output artifact Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 84bf0aaf20..dd2fd82a9f 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -47,13 +47,13 @@ jobs: if: steps.pack-tableau-odbc.outcome == 'success' uses: actions/upload-artifact@v2 with: - name: TableauConnector + name: TableauConnectors path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco - name: Upload Tableau JDBC connector if: steps.pack-tableau-jdbc.outcome == 'success' uses: actions/upload-artifact@v2 with: - name: TableauConnector + name: TableauConnectors path: bi-connectors/TableauConnector/opensearch_sql_jdbc/opensearch_sql_jdbc.taco - name: Upload Power BI ODBC connectors if: steps.pack-powerbi-odbc-os-proj.outcome == 'success' || (steps.prep-powerbi-odbc-amz-os-svc.outcome == 'success' && steps.pack-powerbi-odbc-amz-os-svc.outcome == 'success') From 4cadfd18ab9dfdb04fde21dcba0cb97c60c64f5b Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Mon, 20 Dec 2021 11:56:54 -0800 Subject: [PATCH 16/19] Disabled building Tableau ODBC connector, because it is not ready for shipping Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index dd2fd82a9f..1211a8c873 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -12,11 +12,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 - - name: Pack Tableau ODBC connector - id: pack-tableau-odbc - run: | - zip -r opensearch_sql_odbc.taco . -x *.taco - working-directory: bi-connectors/TableauConnector/opensearch_sql_odbc +# - name: Pack Tableau ODBC connector +# id: pack-tableau-odbc +# run: | +# zip -r opensearch_sql_odbc.taco . -x *.taco +# working-directory: bi-connectors/TableauConnector/opensearch_sql_odbc - name: Pack Tableau JDBC connector id: pack-tableau-jdbc run: | @@ -43,12 +43,12 @@ jobs: run: | zip AmazonOpenSearchService.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector - - name: Upload Tableau ODBC connector - if: steps.pack-tableau-odbc.outcome == 'success' - uses: actions/upload-artifact@v2 - with: - name: TableauConnectors - path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco +# - name: Upload Tableau ODBC connector +# if: steps.pack-tableau-odbc.outcome == 'success' +# uses: actions/upload-artifact@v2 +# with: +# name: TableauConnectors +# path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco - name: Upload Tableau JDBC connector if: steps.pack-tableau-jdbc.outcome == 'success' uses: actions/upload-artifact@v2 From 6e378705eef3c1f779b232680970e895ae85436b Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Mon, 20 Dec 2021 11:59:03 -0800 Subject: [PATCH 17/19] Updated workflow step description Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 1211a8c873..9ffc429a13 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -31,7 +31,7 @@ jobs: run: | zip OpenSearchProject.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector - - name: Prepare the second Power BI ODBC connector + - name: Prepare Power BI ODBC connector for 'Amazon OpenSearch Service' id: prep-powerbi-odbc-amz-os-svc run: | sed -i 's/OpenSearch Project<\/value>/Amazon OpenSearch Service<\/value>/g' resources.resx From ccb52f469f3acdb1144c3ce1279c7be745a862be Mon Sep 17 00:00:00 2001 From: Yury Fridlyand Date: Mon, 20 Dec 2021 13:16:15 -0800 Subject: [PATCH 18/19] Removed packing ODBC driver for Tableau (re: 4cadfd18). Removed Tableau ODBC driver source files since the driver is not supposed to be. Signed-off-by: Yury Fridlyand --- .github/workflows/bi-connectors.yml | 11 - .../opensearch_sql_odbc/README.md | 8 - .../opensearch_sql_odbc/connection-dialog.tcd | 16 - .../opensearch_sql_odbc/connectionBuilder.js | 42 --- .../connectionResolver.tdr | 27 -- .../opensearch_sql_odbc/dialect.tdd | 323 ------------------ .../opensearch_sql_odbc/manifest.xml | 49 --- .../opensearch_sql_odbc.taco | Bin 3643 -> 0 bytes .../opensearch_sql_odbc_dev/README.md | 11 - .../connection-dialog.tcd | 16 - .../connectionBuilder.js | 42 --- .../connectionResolver.tdr | 27 -- .../opensearch_sql_odbc_dev/dialect.tdd | 7 - .../opensearch_sql_odbc_dev/manifest.xml | 21 -- .../opensearch_sql_odbc_dev.taco | Bin 2711 -> 0 bytes 15 files changed, 600 deletions(-) delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/README.md delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/connection-dialog.tcd delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/connectionBuilder.js delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/connectionResolver.tdr delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/dialect.tdd delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/manifest.xml delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/README.md delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/connection-dialog.tcd delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/connectionBuilder.js delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/connectionResolver.tdr delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/dialect.tdd delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/manifest.xml delete mode 100644 bi-connectors/TableauConnector/opensearch_sql_odbc_dev/opensearch_sql_odbc_dev.taco diff --git a/.github/workflows/bi-connectors.yml b/.github/workflows/bi-connectors.yml index 9ffc429a13..6b6124139e 100644 --- a/.github/workflows/bi-connectors.yml +++ b/.github/workflows/bi-connectors.yml @@ -12,11 +12,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1 -# - name: Pack Tableau ODBC connector -# id: pack-tableau-odbc -# run: | -# zip -r opensearch_sql_odbc.taco . -x *.taco -# working-directory: bi-connectors/TableauConnector/opensearch_sql_odbc - name: Pack Tableau JDBC connector id: pack-tableau-jdbc run: | @@ -43,12 +38,6 @@ jobs: run: | zip AmazonOpenSearchService.mez *.png *.m *.resx *.pqm working-directory: bi-connectors/PowerBIConnector -# - name: Upload Tableau ODBC connector -# if: steps.pack-tableau-odbc.outcome == 'success' -# uses: actions/upload-artifact@v2 -# with: -# name: TableauConnectors -# path: bi-connectors/TableauConnector/opensearch_sql_odbc/opensearch_sql_odbc.taco - name: Upload Tableau JDBC connector if: steps.pack-tableau-jdbc.outcome == 'success' uses: actions/upload-artifact@v2 diff --git a/bi-connectors/TableauConnector/opensearch_sql_odbc/README.md b/bi-connectors/TableauConnector/opensearch_sql_odbc/README.md deleted file mode 100644 index c136140744..0000000000 --- a/bi-connectors/TableauConnector/opensearch_sql_odbc/README.md +++ /dev/null @@ -1,8 +0,0 @@ -## opensearch_sql_odbc - -The connector files in `opensearch_sql_odbc` can be used to connect to OpenSearch server in Tableau. - -* These connector files remove and modify a set of unsupported functions and operations. -* It includes set of capabilities to customize and tune connector behavior - -To use this connector with Tableau, [Package the connector](https://tableau.github.io/connector-plugin-sdk/docs/package-sign) and [Run Packaged Connector (TACO file)](https://tableau.github.io/connector-plugin-sdk/docs/run-taco) \ No newline at end of file diff --git a/bi-connectors/TableauConnector/opensearch_sql_odbc/connection-dialog.tcd b/bi-connectors/TableauConnector/opensearch_sql_odbc/connection-dialog.tcd deleted file mode 100644 index f7ae8da245..0000000000 --- a/bi-connectors/TableauConnector/opensearch_sql_odbc/connection-dialog.tcd +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - - - - - - - - diff --git a/bi-connectors/TableauConnector/opensearch_sql_odbc/connectionBuilder.js b/bi-connectors/TableauConnector/opensearch_sql_odbc/connectionBuilder.js deleted file mode 100644 index b5a04d1777..0000000000 --- a/bi-connectors/TableauConnector/opensearch_sql_odbc/connectionBuilder.js +++ /dev/null @@ -1,42 +0,0 @@ -(function dsbuilder(attr){ - var params = {}; - - // Set host information in connection string - params["SERVER"] = attr[connectionHelper.attributeServer]; - params["PORT"] = attr[connectionHelper.attributePort]; - - // Set authentication values in connection string - var authAttrValue = attr[connectionHelper.attributeAuthentication]; - params["Auth"] = attr[connectionHelper.attributeAuthentication]; - if (authAttrValue == "AWS_SIGV4"){ - params["Region"] = attr[connectionHelper.attributeVendor1]; - } else if (authAttrValue == "BASIC"){ - params["UID"] = attr[connectionHelper.attributeUsername]; - params["PWD"] = attr[connectionHelper.attributePassword]; - } - - // Set SSL value in connection string - if (attr[connectionHelper.attributeSSLMode] == "require"){ - params["useSSL"] = "1"; - } else { - params["useSSL"] = "0"; - } - - // Parse additional options and add in connection string - var odbcConnectStringExtrasMap = {}; - const attributeODBCConnectStringExtras = "vendor2"; - if (attributeODBCConnectStringExtras in attr){ - odbcConnectStringExtrasMap = connectionHelper.ParseODBCConnectString(attr[attributeODBCConnectStringExtras]); - } - for (var key in odbcConnectStringExtrasMap){ - params[key] = odbcConnectStringExtrasMap[key]; - } - - // Format the attributes as 'key=value' - var formattedParams = []; - formattedParams.push(connectionHelper.formatKeyValuePair(driverLocator.keywordDriver, driverLocator.locateDriver(attr))); - for (var key in params){ - formattedParams.push(connectionHelper.formatKeyValuePair(key, params[key])); - } - return formattedParams; -}) diff --git a/bi-connectors/TableauConnector/opensearch_sql_odbc/connectionResolver.tdr b/bi-connectors/TableauConnector/opensearch_sql_odbc/connectionResolver.tdr deleted file mode 100644 index 68c376270c..0000000000 --- a/bi-connectors/TableauConnector/opensearch_sql_odbc/connectionResolver.tdr +++ /dev/null @@ -1,27 +0,0 @@ - - - - -