From ca20d16cf8978b3e8ac6ac0c294bee4045582602 Mon Sep 17 00:00:00 2001 From: Yury-Fridlyand Date: Fri, 24 Mar 2023 17:28:09 -0700 Subject: [PATCH] Minor missing changes. Signed-off-by: Yury-Fridlyand --- .../java/org/opensearch/sql/executor/CanPaginateVisitor.java | 3 --- .../src/test/java/org/opensearch/sql/util/TestUtils.java | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/core/src/main/java/org/opensearch/sql/executor/CanPaginateVisitor.java b/core/src/main/java/org/opensearch/sql/executor/CanPaginateVisitor.java index a7ef480ffd..6ea316525d 100644 --- a/core/src/main/java/org/opensearch/sql/executor/CanPaginateVisitor.java +++ b/core/src/main/java/org/opensearch/sql/executor/CanPaginateVisitor.java @@ -33,9 +33,6 @@ public Boolean visitRelation(Relation node, Object context) { return Boolean.FALSE; } - // TODO use storageEngine from the calling PaginatedPlanCache to determine if - // node.getTableQualifiedName is provided by the storage engine. Return false if it's - // not the case. return Boolean.TRUE; } diff --git a/integ-test/src/test/java/org/opensearch/sql/util/TestUtils.java b/integ-test/src/test/java/org/opensearch/sql/util/TestUtils.java index fd48683eab..5de2c75d7b 100644 --- a/integ-test/src/test/java/org/opensearch/sql/util/TestUtils.java +++ b/integ-test/src/test/java/org/opensearch/sql/util/TestUtils.java @@ -846,7 +846,7 @@ public static List> getPermutations(final List items) { public static void verifyIsV1Cursor(JSONObject response) { var legacyCursorPrefixes = Arrays.stream(CursorType.values()) - .map(c -> c.toString() + ":").collect(Collectors.toList()); + .map(c -> c.getId() + ":").collect(Collectors.toList()); verifyCursor(response, legacyCursorPrefixes, "v1"); }