Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further work on spoon shell #8

Open
2 tasks
Bios-Marcel opened this issue Mar 25, 2024 · 0 comments
Open
2 tasks

Further work on spoon shell #8

Bios-Marcel opened this issue Mar 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Bios-Marcel
Copy link
Owner

Bios-Marcel commented Mar 25, 2024

In a very basic form this is usable now, however, it's missing some basic building blocks required for a mature implementation.

Therefore the current WIP will be merged as to not cause too many conflicts. The current implementations doesn't break anything, but it's not production ready.

Building blocks required:

  • Parse Architechture fields and handle accordingly in code
  • Ability to generate / delete shims for manifest

    This will allow us to properly delete dependencies that aren't needed anymore AND we can hardlink existing installations from the users scoop installation, as all we need to do is recreate the shims then. This is much faster than potentially unpacking a zip file / installer.

TODOs from code:

  • Support for different shells (pwsh / powershell / batch / bash / wsl?)
  • Proper support for subshelling (Might not easily work on powershell)

    SOOO, I actually thought there was a severe issue with subshelling. However, during my tests, I always used the lua repl. For some reason, upon exiting the repl, it breaks the terminal session. However, using the node repl for example, doesn't cause the same issue. So this might be a lua or a golang bug afterall. Even greater, this seems to only fail if lua is quit via Ctrl-C, not via the lua exit function.

  • env_set variables:
    • $env:CUSTOM
    • $source variable
  • Prevent install (unpack) if app is already installed in user, instead hardlink (its basically free)
  • uninstall unused ones if shell is called againts
@Bios-Marcel Bios-Marcel added the enhancement New feature or request label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant