Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exception mapping docs to be more readable #288

Closed
krrishdholakia opened this issue Sep 6, 2023 · 7 comments
Closed

Update exception mapping docs to be more readable #288

krrishdholakia opened this issue Sep 6, 2023 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@krrishdholakia
Copy link
Contributor

What's the problem? (if there are multiple - list as bullet points)
Turn this into a 2-d matrix of provider and exceptions that have been mapped. It'll also make it easier to identify any gaps.

Screenshot 2023-09-06 at 10 02 55 AM
@krrishdholakia krrishdholakia added documentation Improvements or additions to documentation good first issue Good for newcomers labels Sep 6, 2023
@pratik9315
Copy link
Contributor

Hey @krrishdholakia! Would love to work on this.

From my understanding, the purpose of this issue is to - Modify the above table so that, it just has a 2*2 table with providers and exceptions column right? That or I'm missing something😅

@krrishdholakia
Copy link
Contributor Author

Yes exactly - we'd love the help @pratik2315

@krrishdholakia
Copy link
Contributor Author

How to run the docs:

git clone https://github.com/BerriAI/litellm.git
cd litellm 
cd docs/my-website
npx docusaurus start

@krrishdholakia
Copy link
Contributor Author

When you make the PR - just add a link to your twitter + linkedin, and we'll give you a shoutout there!

@pratik9315
Copy link
Contributor

How to run the docs:

git clone https://github.com/BerriAI/litellm.git
cd litellm 
cd docs/my-website
npx docusaurus start

Thanks! was just about to ask this!

One final doubt - What about the other 2 columns? Should I just remove them completely or list the information in them somewhere else in the form of bullet points?

@krrishdholakia
Copy link
Contributor Author

I think we can remove them for now and point to the implementation code if anyone's interested -

def exception_type(model, original_exception, custom_llm_provider):

But I trust you to make the right call / do what you think would be useful for you.

@krrishdholakia
Copy link
Contributor Author

closing as this is now done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants